Page MenuHomePhabricator
Create Task
Maniphest T5561

Hide empty panels
Closed, ResolvedPublic
Actions

Description

I'm trying to mimic old dashboard behavior, where users were seeing only relevant into:

  • who have have problem commits see them
  • who have needs attention commits see them

So far I was able to create tab panel with 2 tabs and for me 1st tab is always empty (because nobody reopens commits to me), but for others 2nd tab is always empty (because their don't audit other commits).

I think it would be best to hide tab when it don't have any info on it.

In case if it happens, that each tab on tab panel is empty, then whole tab panel can be hidden. Tricky moment is that if that's the only content on the left, then right column would have 100% width now.

Event Timeline

aik099 created this task.Jul 7 2014, 9:33 AM
aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Dashboards.
aik099 added a subscriber: aik099.
chad added a subscriber: chad.Jul 7 2014, 9:07 PM

From a performance perspective, this is very expensive. From a product perspective, this makes the product seem buggy (tabs appearing/disappearing). Our feelings on tabbed interfaces is that they should only contain secondary information, non-essential.

chad added a comment.EditedJul 7 2014, 9:18 PM

I would recommend either installing 2 different Audit panels, which should do the right thing, or build 2 different Dashboards. This is what we're currently expecting installs to do. I don't think we have any current intentions to hide panels with no results, it'd be inconsistent with the rest of the product and difficult to support.

aik099 added a comment.Jul 8 2014, 6:40 AM

I'll placed 2 audit panels on 1 dashboard. Thanks.

btrahan closed this task as Resolved.Jul 10 2014, 10:47 PM
btrahan claimed this task.
Phabricator · Built by Phacility