PhutilLintEngine.php
View Options

	<?php

	/**
	* Lint engine which enforces libphutil rules.
	*
	* TODO: Deal with PhabricatorLintEngine extending this and then finalize it.
	*
	* @group linter
	*/
	class PhutilLintEngine extends ArcanistLintEngine {

	public function buildLinters() {
	$linters = array();

	$paths = $this->getPaths();

	$linters[] = id(new ArcanistPhutilLibraryLinter())->setPaths($paths);

	// Remaining linters operate on file contents and ignore removed files.
	foreach ($paths as $key => $path) {
	if (!$this->pathExists($path)) {
	unset($paths[$key]);
	}
	if (preg_match('@^externals/@', $path)) {
	// Third-party stuff lives in /externals/; don't run lint engines
	// against it.
	unset($paths[$key]);
	}
	if (preg_match('(\\.lint-test$)', $path)) {
	// Don't try to lint these, since they're tests for linters and
	// often have intentional lint errors.
	unset($paths[$key]);
	}
	}

	$linters[] = id(new ArcanistFilenameLinter())->setPaths($paths);

	// Skip directories and lint only regular files in remaining linters.
	foreach ($paths as $key => $path) {
	if ($this->getCommitHookMode()) {
	continue;
	}
	if (!is_file($this->getFilePathOnDisk($path))) {
	unset($paths[$key]);
	}
	}

	$linters[] = id(new ArcanistGeneratedLinter())->setPaths($paths);
	$linters[] = id(new ArcanistNoLintLinter())->setPaths($paths);
	$linters[] = id(new ArcanistTextLinter())->setPaths($paths);
	$linters[] = id(new ArcanistSpellingLinter())->setPaths($paths);

	$php_paths = preg_grep('/\.php$/', $paths);

	$xhpast_linter = id(new ArcanistXHPASTLinter())
	->setCustomSeverityMap($this->getXHPASTSeverityMap())
	->setPaths($php_paths);
	$linters[] = $xhpast_linter;

	$linters[] = id(new ArcanistPhutilXHPASTLinter())
	->setXHPASTLinter($xhpast_linter)
	->setPaths($php_paths);

	$merge_conflict_linter = id(new ArcanistMergeConflictLinter());

	foreach ($paths as $path) {
	$merge_conflict_linter->addPath($path);
	$merge_conflict_linter->addData($path, $this->loadData($path));
	}

	$linters[] = $merge_conflict_linter;

	return $linters;
	}

	private function getXHPASTSeverityMap() {
	$error = ArcanistLintSeverity::SEVERITY_ERROR;
	$warning = ArcanistLintSeverity::SEVERITY_WARNING;
	$advice = ArcanistLintSeverity::SEVERITY_ADVICE;

	return array(
	ArcanistXHPASTLinter::LINT_PHP_53_FEATURES => $error,
	ArcanistXHPASTLinter::LINT_PHP_54_FEATURES => $error,
	ArcanistXHPASTLinter::LINT_COMMENT_SPACING => $error,
	ArcanistXHPASTLinter::LINT_RAGGED_CLASSTREE_EDGE => $warning,
	ArcanistXHPASTLinter::LINT_TODO_COMMENT => $advice,
	);
	}
	}

File Metadata

Mime Type: text/x-php
Expires: Wed, Jun 9, 2:32 AM (1 d, 23 h)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 3379227
Default Alt Text: PhutilLintEngine.php (2 KB)

PhutilLintEngine.php
No OneTemporary
Actions

PhutilLintEngine.php
View Options

File Metadata

Event Timeline

PhutilLintEngine.phpNo OneTemporaryActions

PhutilLintEngine.phpView Options

File Metadata

Event Timeline

PhutilLintEngine.php
No OneTemporary
Actions

PhutilLintEngine.php
View Options