Page MenuHomePhabricator
Files F18586150

D11179.id26849.diff
No OneTemporary
Actions

D11179.id26849.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1385,6 +1385,7 @@
'PhabricatorBcryptPasswordHasher' => 'infrastructure/util/password/PhabricatorBcryptPasswordHasher.php',
'PhabricatorBinariesSetupCheck' => 'applications/config/check/PhabricatorBinariesSetupCheck.php',
'PhabricatorBitbucketAuthProvider' => 'applications/auth/provider/PhabricatorBitbucketAuthProvider.php',
+ 'PhabricatorBoolCustomField' => 'infrastructure/customfield/standard/PhabricatorBoolCustomField.php',
'PhabricatorBot' => 'infrastructure/daemon/bot/PhabricatorBot.php',
'PhabricatorBotBaseStreamingProtocolAdapter' => 'infrastructure/daemon/bot/adapter/PhabricatorBotBaseStreamingProtocolAdapter.php',
'PhabricatorBotChannel' => 'infrastructure/daemon/bot/target/PhabricatorBotChannel.php',
@@ -1543,6 +1544,7 @@
'PhabricatorCountdownSearchEngine' => 'applications/countdown/query/PhabricatorCountdownSearchEngine.php',
'PhabricatorCountdownView' => 'applications/countdown/view/PhabricatorCountdownView.php',
'PhabricatorCountdownViewController' => 'applications/countdown/controller/PhabricatorCountdownViewController.php',
+ 'PhabricatorCredentialCustomField' => 'infrastructure/customfield/standard/PhabricatorCredentialCustomField.php',
'PhabricatorCredentialsUsedByObjectEdgeType' => 'applications/passphrase/edge/PhabricatorCredentialsUsedByObjectEdgeType.php',
'PhabricatorCrumbView' => 'view/layout/PhabricatorCrumbView.php',
'PhabricatorCrumbsView' => 'view/layout/PhabricatorCrumbsView.php',
@@ -1551,7 +1553,7 @@
'PhabricatorCustomFieldAttachment' => 'infrastructure/customfield/field/PhabricatorCustomFieldAttachment.php',
'PhabricatorCustomFieldConfigOptionType' => 'infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php',
'PhabricatorCustomFieldDataNotAvailableException' => 'infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php',
- 'PhabricatorCustomFieldImplementationIncompleteException' => 'infrastructure/customfield/exception/PhabricatorCustomFieldImplementationIncompleteException.php',
+ 'PhabricatorCustomFieldIncompleteImplementationException' => 'infrastructure/customfield/exception/PhabricatorCustomFieldIncompleteImplementationException.php',
'PhabricatorCustomFieldIndexStorage' => 'infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php',
'PhabricatorCustomFieldInterface' => 'infrastructure/customfield/interface/PhabricatorCustomFieldInterface.php',
'PhabricatorCustomFieldList' => 'infrastructure/customfield/field/PhabricatorCustomFieldList.php',
@@ -1642,6 +1644,7 @@
'PhabricatorDashboardViewController' => 'applications/dashboard/controller/PhabricatorDashboardViewController.php',
'PhabricatorDataNotAttachedException' => 'infrastructure/storage/lisk/PhabricatorDataNotAttachedException.php',
'PhabricatorDatabaseSetupCheck' => 'applications/config/check/PhabricatorDatabaseSetupCheck.php',
+ 'PhabricatorDateCustomField' => 'infrastructure/customfield/standard/PhabricatorDateCustomField.php',
'PhabricatorDebugController' => 'applications/system/controller/PhabricatorDebugController.php',
'PhabricatorDefaultFileStorageEngineSelector' => 'applications/files/engineselector/PhabricatorDefaultFileStorageEngineSelector.php',
'PhabricatorDefaultSearchEngineSelector' => 'applications/search/selector/PhabricatorDefaultSearchEngineSelector.php',
@@ -1820,6 +1823,7 @@
'PhabricatorHarbormasterConfigOptions' => 'applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php',
'PhabricatorHash' => 'infrastructure/util/PhabricatorHash.php',
'PhabricatorHashTestCase' => 'infrastructure/util/__tests__/PhabricatorHashTestCase.php',
+ 'PhabricatorHeaderCustomField' => 'infrastructure/customfield/standard/PhabricatorHeaderCustomField.php',
'PhabricatorHelpApplication' => 'applications/help/application/PhabricatorHelpApplication.php',
'PhabricatorHelpController' => 'applications/help/controller/PhabricatorHelpController.php',
'PhabricatorHelpEditorProtocolController' => 'applications/help/controller/PhabricatorHelpEditorProtocolController.php',
@@ -1844,6 +1848,7 @@
'PhabricatorInlineCommentInterface' => 'infrastructure/diff/interface/PhabricatorInlineCommentInterface.php',
'PhabricatorInlineCommentPreviewController' => 'infrastructure/diff/PhabricatorInlineCommentPreviewController.php',
'PhabricatorInlineSummaryView' => 'infrastructure/diff/view/PhabricatorInlineSummaryView.php',
+ 'PhabricatorIntCustomField' => 'infrastructure/customfield/standard/PhabricatorIntCustomField.php',
'PhabricatorInternationalizationManagementExtractWorkflow' => 'infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php',
'PhabricatorInternationalizationManagementWorkflow' => 'infrastructure/internationalization/management/PhabricatorInternationalizationManagementWorkflow.php',
'PhabricatorInvalidConfigSetupCheck' => 'applications/config/check/PhabricatorInvalidConfigSetupCheck.php',
@@ -2061,6 +2066,7 @@
'PhabricatorPHIDConstants' => 'applications/phid/PhabricatorPHIDConstants.php',
'PhabricatorPHIDInterface' => 'applications/phid/interface/PhabricatorPHIDInterface.php',
'PhabricatorPHIDType' => 'applications/phid/type/PhabricatorPHIDType.php',
+ 'PhabricatorPHIDsCustomField' => 'infrastructure/customfield/standard/PhabricatorPHIDsCustomField.php',
'PhabricatorPHPASTApplication' => 'applications/phpast/application/PhabricatorPHPASTApplication.php',
'PhabricatorPHPConfigSetupCheck' => 'applications/config/check/PhabricatorPHPConfigSetupCheck.php',
'PhabricatorPHPMailerConfigOptions' => 'applications/config/option/PhabricatorPHPMailerConfigOptions.php',
@@ -2189,7 +2195,7 @@
'PhabricatorProjectCustomFieldStringIndex' => 'applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php',
'PhabricatorProjectDAO' => 'applications/project/storage/PhabricatorProjectDAO.php',
'PhabricatorProjectDatasource' => 'applications/project/typeahead/PhabricatorProjectDatasource.php',
- 'PhabricatorProjectDescriptionField' => 'applications/project/customfield/PhabricatorProjectDescriptionField.php',
+ 'PhabricatorProjectDescriptionCustomField' => 'applications/project/customfield/PhabricatorProjectDescriptionCustomField.php',
'PhabricatorProjectEditDetailsController' => 'applications/project/controller/PhabricatorProjectEditDetailsController.php',
'PhabricatorProjectEditIconController' => 'applications/project/controller/PhabricatorProjectEditIconController.php',
'PhabricatorProjectEditMainController' => 'applications/project/controller/PhabricatorProjectEditMainController.php',
@@ -2235,6 +2241,7 @@
'PhabricatorRemarkupControl' => 'view/form/control/PhabricatorRemarkupControl.php',
'PhabricatorRemarkupCowsayBlockInterpreter' => 'infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php',
'PhabricatorRemarkupCustomBlockRule' => 'infrastructure/markup/rule/PhabricatorRemarkupCustomBlockRule.php',
+ 'PhabricatorRemarkupCustomField' => 'infrastructure/customfield/standard/PhabricatorRemarkupCustomField.php',
'PhabricatorRemarkupCustomInlineRule' => 'infrastructure/markup/rule/PhabricatorRemarkupCustomInlineRule.php',
'PhabricatorRemarkupFigletBlockInterpreter' => 'infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php',
'PhabricatorRemarkupGraphvizBlockInterpreter' => 'infrastructure/markup/interpreter/PhabricatorRemarkupGraphvizBlockInterpreter.php',
@@ -2379,6 +2386,7 @@
'PhabricatorSearchWorker' => 'applications/search/worker/PhabricatorSearchWorker.php',
'PhabricatorSecurityConfigOptions' => 'applications/config/option/PhabricatorSecurityConfigOptions.php',
'PhabricatorSecuritySetupCheck' => 'applications/config/check/PhabricatorSecuritySetupCheck.php',
+ 'PhabricatorSelectCustomField' => 'infrastructure/customfield/standard/PhabricatorSelectCustomField.php',
'PhabricatorSendGridConfigOptions' => 'applications/config/option/PhabricatorSendGridConfigOptions.php',
'PhabricatorSessionsSettingsPanel' => 'applications/settings/panel/PhabricatorSessionsSettingsPanel.php',
'PhabricatorSettingsAddEmailAction' => 'applications/settings/action/PhabricatorSettingsAddEmailAction.php',
@@ -2416,17 +2424,7 @@
'PhabricatorSortTableUIExample' => 'applications/uiexample/examples/PhabricatorSortTableUIExample.php',
'PhabricatorSourceCodeView' => 'view/layout/PhabricatorSourceCodeView.php',
'PhabricatorStandardCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardCustomField.php',
- 'PhabricatorStandardCustomFieldBool' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php',
- 'PhabricatorStandardCustomFieldCredential' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php',
- 'PhabricatorStandardCustomFieldDate' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php',
- 'PhabricatorStandardCustomFieldHeader' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php',
- 'PhabricatorStandardCustomFieldInt' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php',
'PhabricatorStandardCustomFieldInterface' => 'infrastructure/customfield/interface/PhabricatorStandardCustomFieldInterface.php',
- 'PhabricatorStandardCustomFieldPHIDs' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php',
- 'PhabricatorStandardCustomFieldRemarkup' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php',
- 'PhabricatorStandardCustomFieldSelect' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php',
- 'PhabricatorStandardCustomFieldText' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php',
- 'PhabricatorStandardCustomFieldUsers' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php',
'PhabricatorStandardPageView' => 'view/page/PhabricatorStandardPageView.php',
'PhabricatorStatusController' => 'applications/system/controller/PhabricatorStatusController.php',
'PhabricatorStatusUIExample' => 'applications/uiexample/examples/PhabricatorStatusUIExample.php',
@@ -2478,6 +2476,7 @@
'PhabricatorTestNoCycleEdgeType' => 'applications/transactions/edges/PhabricatorTestNoCycleEdgeType.php',
'PhabricatorTestStorageEngine' => 'applications/files/engine/PhabricatorTestStorageEngine.php',
'PhabricatorTestWorker' => 'infrastructure/daemon/workers/__tests__/PhabricatorTestWorker.php',
+ 'PhabricatorTextCustomField' => 'infrastructure/customfield/standard/PhabricatorTextCustomField.php',
'PhabricatorTime' => 'infrastructure/time/PhabricatorTime.php',
'PhabricatorTimeGuard' => 'infrastructure/time/PhabricatorTimeGuard.php',
'PhabricatorTimeTestCase' => 'infrastructure/time/__tests__/PhabricatorTimeTestCase.php',
@@ -2555,6 +2554,7 @@
'PhabricatorUserTestCase' => 'applications/people/storage/__tests__/PhabricatorUserTestCase.php',
'PhabricatorUserTitleField' => 'applications/people/customfield/PhabricatorUserTitleField.php',
'PhabricatorUserTransaction' => 'applications/people/storage/PhabricatorUserTransaction.php',
+ 'PhabricatorUsersCustomField' => 'infrastructure/customfield/standard/PhabricatorUsersCustomField.php',
'PhabricatorUsersPolicyRule' => 'applications/policy/rule/PhabricatorUsersPolicyRule.php',
'PhabricatorVCSResponse' => 'applications/repository/response/PhabricatorVCSResponse.php',
'PhabricatorWatcherHasObjectEdgeType' => 'applications/transactions/edges/PhabricatorWatcherHasObjectEdgeType.php',
@@ -4546,6 +4546,7 @@
'PhabricatorBcryptPasswordHasher' => 'PhabricatorPasswordHasher',
'PhabricatorBinariesSetupCheck' => 'PhabricatorSetupCheck',
'PhabricatorBitbucketAuthProvider' => 'PhabricatorOAuth1AuthProvider',
+ 'PhabricatorBoolCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorBot' => 'PhabricatorDaemon',
'PhabricatorBotBaseStreamingProtocolAdapter' => 'PhabricatorBaseProtocolAdapter',
'PhabricatorBotChannel' => 'PhabricatorBotTarget',
@@ -4721,13 +4722,14 @@
'PhabricatorCountdownSearchEngine' => 'PhabricatorApplicationSearchEngine',
'PhabricatorCountdownView' => 'AphrontTagView',
'PhabricatorCountdownViewController' => 'PhabricatorCountdownController',
+ 'PhabricatorCredentialCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorCredentialsUsedByObjectEdgeType' => 'PhabricatorEdgeType',
'PhabricatorCrumbView' => 'AphrontView',
'PhabricatorCrumbsView' => 'AphrontView',
'PhabricatorCursorPagedPolicyAwareQuery' => 'PhabricatorPolicyAwareQuery',
'PhabricatorCustomFieldConfigOptionType' => 'PhabricatorConfigOptionType',
'PhabricatorCustomFieldDataNotAvailableException' => 'Exception',
- 'PhabricatorCustomFieldImplementationIncompleteException' => 'Exception',
+ 'PhabricatorCustomFieldIncompleteImplementationException' => 'Exception',
'PhabricatorCustomFieldIndexStorage' => 'PhabricatorLiskDAO',
'PhabricatorCustomFieldList' => 'Phobject',
'PhabricatorCustomFieldMonogramParser' => 'Phobject',
@@ -4832,6 +4834,7 @@
'PhabricatorDashboardViewController' => 'PhabricatorDashboardController',
'PhabricatorDataNotAttachedException' => 'Exception',
'PhabricatorDatabaseSetupCheck' => 'PhabricatorSetupCheck',
+ 'PhabricatorDateCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorDebugController' => 'PhabricatorController',
'PhabricatorDefaultFileStorageEngineSelector' => 'PhabricatorFileStorageEngineSelector',
'PhabricatorDefaultSearchEngineSelector' => 'PhabricatorSearchEngineSelector',
@@ -5018,6 +5021,7 @@
'PhabricatorHarbormasterApplication' => 'PhabricatorApplication',
'PhabricatorHarbormasterConfigOptions' => 'PhabricatorApplicationConfigOptions',
'PhabricatorHashTestCase' => 'PhabricatorTestCase',
+ 'PhabricatorHeaderCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorHelpApplication' => 'PhabricatorApplication',
'PhabricatorHelpController' => 'PhabricatorController',
'PhabricatorHelpEditorProtocolController' => 'PhabricatorHelpController',
@@ -5041,6 +5045,7 @@
'PhabricatorInlineCommentInterface' => 'PhabricatorMarkupInterface',
'PhabricatorInlineCommentPreviewController' => 'PhabricatorController',
'PhabricatorInlineSummaryView' => 'AphrontView',
+ 'PhabricatorIntCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorInternationalizationManagementExtractWorkflow' => 'PhabricatorInternationalizationManagementWorkflow',
'PhabricatorInternationalizationManagementWorkflow' => 'PhabricatorManagementWorkflow',
'PhabricatorInvalidConfigSetupCheck' => 'PhabricatorSetupCheck',
@@ -5245,6 +5250,7 @@
'PhabricatorOwnersPackageTestCase' => 'PhabricatorTestCase',
'PhabricatorOwnersPath' => 'PhabricatorOwnersDAO',
'PhabricatorPHDConfigOptions' => 'PhabricatorApplicationConfigOptions',
+ 'PhabricatorPHIDsCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorPHPASTApplication' => 'PhabricatorApplication',
'PhabricatorPHPConfigSetupCheck' => 'PhabricatorSetupCheck',
'PhabricatorPHPMailerConfigOptions' => 'PhabricatorApplicationConfigOptions',
@@ -5402,7 +5408,7 @@
'PhabricatorProjectCustomFieldStringIndex' => 'PhabricatorCustomFieldStringIndexStorage',
'PhabricatorProjectDAO' => 'PhabricatorLiskDAO',
'PhabricatorProjectDatasource' => 'PhabricatorTypeaheadDatasource',
- 'PhabricatorProjectDescriptionField' => 'PhabricatorProjectStandardCustomField',
+ 'PhabricatorProjectDescriptionCustomField' => 'PhabricatorProjectStandardCustomField',
'PhabricatorProjectEditDetailsController' => 'PhabricatorProjectController',
'PhabricatorProjectEditIconController' => 'PhabricatorProjectController',
'PhabricatorProjectEditMainController' => 'PhabricatorProjectController',
@@ -5448,6 +5454,7 @@
'PhabricatorRemarkupControl' => 'AphrontFormTextAreaControl',
'PhabricatorRemarkupCowsayBlockInterpreter' => 'PhutilRemarkupBlockInterpreter',
'PhabricatorRemarkupCustomBlockRule' => 'PhutilRemarkupBlockRule',
+ 'PhabricatorRemarkupCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorRemarkupCustomInlineRule' => 'PhutilRemarkupRule',
'PhabricatorRemarkupFigletBlockInterpreter' => 'PhutilRemarkupBlockInterpreter',
'PhabricatorRemarkupGraphvizBlockInterpreter' => 'PhutilRemarkupBlockInterpreter',
@@ -5618,6 +5625,7 @@
'PhabricatorSearchWorker' => 'PhabricatorWorker',
'PhabricatorSecurityConfigOptions' => 'PhabricatorApplicationConfigOptions',
'PhabricatorSecuritySetupCheck' => 'PhabricatorSetupCheck',
+ 'PhabricatorSelectCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorSendGridConfigOptions' => 'PhabricatorApplicationConfigOptions',
'PhabricatorSessionsSettingsPanel' => 'PhabricatorSettingsPanel',
'PhabricatorSettingsAddEmailAction' => 'PhabricatorSystemAction',
@@ -5660,16 +5668,6 @@
'PhabricatorSortTableUIExample' => 'PhabricatorUIExample',
'PhabricatorSourceCodeView' => 'AphrontView',
'PhabricatorStandardCustomField' => 'PhabricatorCustomField',
- 'PhabricatorStandardCustomFieldBool' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldCredential' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldDate' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldHeader' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldInt' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldPHIDs' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldRemarkup' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldSelect' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldText' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldUsers' => 'PhabricatorStandardCustomFieldPHIDs',
'PhabricatorStandardPageView' => 'PhabricatorBarePageView',
'PhabricatorStatusController' => 'PhabricatorController',
'PhabricatorStatusUIExample' => 'PhabricatorUIExample',
@@ -5714,6 +5712,7 @@
'PhabricatorTestNoCycleEdgeType' => 'PhabricatorEdgeType',
'PhabricatorTestStorageEngine' => 'PhabricatorFileStorageEngine',
'PhabricatorTestWorker' => 'PhabricatorWorker',
+ 'PhabricatorTextCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorTimeTestCase' => 'PhabricatorTestCase',
'PhabricatorTimezoneSetupCheck' => 'PhabricatorSetupCheck',
'PhabricatorToken' => array(
@@ -5803,6 +5802,7 @@
'PhabricatorUserTestCase' => 'PhabricatorTestCase',
'PhabricatorUserTitleField' => 'PhabricatorUserCustomField',
'PhabricatorUserTransaction' => 'PhabricatorApplicationTransaction',
+ 'PhabricatorUsersCustomField' => 'PhabricatorPHIDsCustomField',
'PhabricatorUsersPolicyRule' => 'PhabricatorPolicyRule',
'PhabricatorVCSResponse' => 'AphrontResponse',
'PhabricatorWatcherHasObjectEdgeType' => 'PhabricatorEdgeType',
diff --git a/src/applications/differential/customfield/DifferentialCoreCustomField.php b/src/applications/differential/customfield/DifferentialCoreCustomField.php
--- a/src/applications/differential/customfield/DifferentialCoreCustomField.php
+++ b/src/applications/differential/customfield/DifferentialCoreCustomField.php
@@ -17,7 +17,7 @@
protected function writeValueToRevision(
DifferentialRevision $revision,
$value) {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
protected function isCoreFieldRequired() {
@@ -32,7 +32,7 @@
}
protected function getCoreFieldRequiredErrorString() {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
public function validateApplicationTransactions(
diff --git a/src/applications/differential/customfield/DifferentialCustomField.php b/src/applications/differential/customfield/DifferentialCustomField.php
--- a/src/applications/differential/customfield/DifferentialCustomField.php
+++ b/src/applications/differential/customfield/DifferentialCustomField.php
@@ -203,7 +203,7 @@
if ($this->getProxy()) {
return $this->getProxy()->renderCommitMessageValue($handles);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
diff --git a/src/applications/project/customfield/PhabricatorProjectDescriptionField.php b/src/applications/project/customfield/PhabricatorProjectDescriptionCustomField.php
rename from src/applications/project/customfield/PhabricatorProjectDescriptionField.php
rename to src/applications/project/customfield/PhabricatorProjectDescriptionCustomField.php
--- a/src/applications/project/customfield/PhabricatorProjectDescriptionField.php
+++ b/src/applications/project/customfield/PhabricatorProjectDescriptionCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorProjectDescriptionField
+final class PhabricatorProjectDescriptionCustomField
extends PhabricatorProjectStandardCustomField {
public function createFields($object) {
diff --git a/src/applications/releeph/field/specification/ReleephFieldSpecification.php b/src/applications/releeph/field/specification/ReleephFieldSpecification.php
--- a/src/applications/releeph/field/specification/ReleephFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephFieldSpecification.php
@@ -41,7 +41,7 @@
public function getRequiredStorageKey() {
$key = $this->getStorageKey();
if ($key === null) {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
if (strpos($key, '.') !== false) {
/**
@@ -183,11 +183,11 @@
}
public function renderLabelForCommitMessage() {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
public function renderValueForCommitMessage() {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
public function shouldAppearOnRevertMessage() {
@@ -222,7 +222,7 @@
}
public function getMarkupText($field) {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
final public function getMarkupEngineOutput() {
diff --git a/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php b/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
--- a/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
@@ -20,7 +20,7 @@
abstract public function getDescriptionForLevel($level);
public function getStorageKey() {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
public function renderPropertyViewValue(array $handles) {
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php
@@ -1,7 +1,6 @@
<?php
-final class PhabricatorCustomFieldDataNotAvailableException
- extends Exception {
+final class PhabricatorCustomFieldDataNotAvailableException extends Exception {
public function __construct(PhabricatorCustomField $field) {
$key = $field->getFieldKey();
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldImplementationIncompleteException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldIncompleteImplementationException.php
rename from src/infrastructure/customfield/exception/PhabricatorCustomFieldImplementationIncompleteException.php
rename to src/infrastructure/customfield/exception/PhabricatorCustomFieldIncompleteImplementationException.php
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldImplementationIncompleteException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldIncompleteImplementationException.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorCustomFieldImplementationIncompleteException
+final class PhabricatorCustomFieldIncompleteImplementationException
extends Exception {
public function __construct(
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php
@@ -1,4 +1,3 @@
<?php
-final class PhabricatorCustomFieldNotAttachedException
- extends Exception {}
+final class PhabricatorCustomFieldNotAttachedException extends Exception {}
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php
@@ -1,7 +1,6 @@
<?php
-final class PhabricatorCustomFieldNotProxyException
- extends Exception {
+final class PhabricatorCustomFieldNotProxyException extends Exception {
public function __construct(PhabricatorCustomField $field) {
$key = $field->getFieldKey();
diff --git a/src/infrastructure/customfield/field/PhabricatorCustomField.php b/src/infrastructure/customfield/field/PhabricatorCustomField.php
--- a/src/infrastructure/customfield/field/PhabricatorCustomField.php
+++ b/src/infrastructure/customfield/field/PhabricatorCustomField.php
@@ -165,7 +165,7 @@
if ($this->proxy) {
return $this->proxy->getFieldKey();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException(
+ throw new PhabricatorCustomFieldIncompleteImplementationException(
$this,
$field_key_is_incomplete = true);
}
@@ -525,7 +525,7 @@
if ($this->proxy) {
return $this->proxy->newStorageObject();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -544,7 +544,7 @@
if ($this->proxy) {
return $this->proxy->getValueForStorage();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -568,7 +568,7 @@
if ($this->proxy) {
return $this->proxy->setValueFromStorage($value);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -652,7 +652,7 @@
*/
protected function newStringIndexStorage() {
// NOTE: This intentionally isn't proxied, to avoid call cycles.
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -666,7 +666,7 @@
*/
protected function newNumericIndexStorage() {
// NOTE: This intentionally isn't proxied, to avoid call cycles.
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -724,7 +724,7 @@
$engine,
$request);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -749,7 +749,7 @@
$query,
$value);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -776,7 +776,7 @@
$value,
$handles);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1121,7 +1121,7 @@
if ($this->proxy) {
return $this->proxy->readValueFromRequest($request);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1154,7 +1154,7 @@
if ($this->proxy) {
return $this->proxy->renderEditControl($handles);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1190,7 +1190,7 @@
if ($this->proxy) {
return $this->proxy->renderPropertyViewValue($handles);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1248,7 +1248,7 @@
if ($this->proxy) {
return $this->proxy->renderOnListItem($view);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1299,7 +1299,7 @@
if ($this->proxy) {
return $this->proxy->getConduitDictionaryValue();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1345,7 +1345,7 @@
if ($this->proxy) {
return $this->proxy->getHeraldFieldValue();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1359,7 +1359,7 @@
if ($this->proxy) {
return $this->proxy->getHeraldFieldConditions();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
diff --git a/src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php b/src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php
--- a/src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php
+++ b/src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php
@@ -1,7 +1,6 @@
<?php
-abstract class PhabricatorCustomFieldMonogramParser
- extends Phobject {
+abstract class PhabricatorCustomFieldMonogramParser extends Phobject {
abstract protected function getPrefixes();
abstract protected function getSuffixes();
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php b/src/infrastructure/customfield/standard/PhabricatorBoolCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php
rename to src/infrastructure/customfield/standard/PhabricatorBoolCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php
+++ b/src/infrastructure/customfield/standard/PhabricatorBoolCustomField.php
@@ -1,7 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldBool
- extends PhabricatorStandardCustomField {
+final class PhabricatorBoolCustomField extends PhabricatorStandardCustomField {
public function getFieldType() {
return 'bool';
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php b/src/infrastructure/customfield/standard/PhabricatorCredentialCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php
rename to src/infrastructure/customfield/standard/PhabricatorCredentialCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php
+++ b/src/infrastructure/customfield/standard/PhabricatorCredentialCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldCredential
+final class PhabricatorCredentialCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php b/src/infrastructure/customfield/standard/PhabricatorDateCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php
rename to src/infrastructure/customfield/standard/PhabricatorDateCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php
+++ b/src/infrastructure/customfield/standard/PhabricatorDateCustomField.php
@@ -1,7 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldDate
- extends PhabricatorStandardCustomField {
+final class PhabricatorDateCustomField extends PhabricatorStandardCustomField {
public function getFieldType() {
return 'date';
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php b/src/infrastructure/customfield/standard/PhabricatorHeaderCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php
rename to src/infrastructure/customfield/standard/PhabricatorHeaderCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php
+++ b/src/infrastructure/customfield/standard/PhabricatorHeaderCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldHeader
+final class PhabricatorHeaderCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php b/src/infrastructure/customfield/standard/PhabricatorIntCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php
rename to src/infrastructure/customfield/standard/PhabricatorIntCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php
+++ b/src/infrastructure/customfield/standard/PhabricatorIntCustomField.php
@@ -1,7 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldInt
- extends PhabricatorStandardCustomField {
+final class PhabricatorIntCustomField extends PhabricatorStandardCustomField {
public function getFieldType() {
return 'int';
@@ -113,5 +112,4 @@
}
}
-
}
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php b/src/infrastructure/customfield/standard/PhabricatorPHIDsCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
rename to src/infrastructure/customfield/standard/PhabricatorPHIDsCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
+++ b/src/infrastructure/customfield/standard/PhabricatorPHIDsCustomField.php
@@ -3,7 +3,7 @@
/**
* Common code for standard field types which store lists of PHIDs.
*/
-abstract class PhabricatorStandardCustomFieldPHIDs
+abstract class PhabricatorPHIDsCustomField
extends PhabricatorStandardCustomField {
public function buildFieldIndexes() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php b/src/infrastructure/customfield/standard/PhabricatorRemarkupCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
rename to src/infrastructure/customfield/standard/PhabricatorRemarkupCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
+++ b/src/infrastructure/customfield/standard/PhabricatorRemarkupCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldRemarkup
+final class PhabricatorRemarkupCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
@@ -73,5 +73,4 @@
);
}
-
}
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php b/src/infrastructure/customfield/standard/PhabricatorSelectCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php
rename to src/infrastructure/customfield/standard/PhabricatorSelectCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php
+++ b/src/infrastructure/customfield/standard/PhabricatorSelectCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldSelect
+final class PhabricatorSelectCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
@@ -1,7 +1,6 @@
<?php
-abstract class PhabricatorStandardCustomField
- extends PhabricatorCustomField {
+abstract class PhabricatorStandardCustomField extends PhabricatorCustomField {
private $rawKey;
private $fieldKey;
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php b/src/infrastructure/customfield/standard/PhabricatorTextCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php
rename to src/infrastructure/customfield/standard/PhabricatorTextCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php
+++ b/src/infrastructure/customfield/standard/PhabricatorTextCustomField.php
@@ -1,7 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldText
- extends PhabricatorStandardCustomField {
+final class PhabricatorTextCustomField extends PhabricatorStandardCustomField {
public function getFieldType() {
return 'text';
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php b/src/infrastructure/customfield/standard/PhabricatorUsersCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php
rename to src/infrastructure/customfield/standard/PhabricatorUsersCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php
+++ b/src/infrastructure/customfield/standard/PhabricatorUsersCustomField.php
@@ -1,7 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldUsers
- extends PhabricatorStandardCustomFieldPHIDs {
+final class PhabricatorUsersCustomField extends PhabricatorPHIDsCustomField {
public function getFieldType() {
return 'users';
diff --git a/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php b/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php
--- a/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php
+++ b/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php
@@ -1,7 +1,6 @@
<?php
-abstract class PhabricatorCustomFieldIndexStorage
- extends PhabricatorLiskDAO {
+abstract class PhabricatorCustomFieldIndexStorage extends PhabricatorLiskDAO {
protected $objectPHID;
protected $indexKey;
diff --git a/src/infrastructure/customfield/storage/PhabricatorCustomFieldStorage.php b/src/infrastructure/customfield/storage/PhabricatorCustomFieldStorage.php
--- a/src/infrastructure/customfield/storage/PhabricatorCustomFieldStorage.php
+++ b/src/infrastructure/customfield/storage/PhabricatorCustomFieldStorage.php
@@ -1,7 +1,6 @@
<?php
-abstract class PhabricatorCustomFieldStorage
- extends PhabricatorLiskDAO {
+abstract class PhabricatorCustomFieldStorage extends PhabricatorLiskDAO {
protected $objectPHID;
protected $fieldIndex;

File Metadata

Mime Type
text/plain
Expires
Sep 12 2025, 5:39 PM (8 w, 4 d ago)
Storage Engine
amazon-s3
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
phabricator/secure/ed/ji/uh252oqznyz2xm2g
Default Alt Text
D11179.id26849.diff (40 KB)

Event Timeline

Phabricator · Built by Phacility