Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F18585724
D11179.id26842.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
27 KB
Referenced Files
None
Subscribers
None
D11179.id26842.diff
View Options
diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -1551,7 +1551,7 @@
'PhabricatorCustomFieldAttachment' => 'infrastructure/customfield/field/PhabricatorCustomFieldAttachment.php',
'PhabricatorCustomFieldConfigOptionType' => 'infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php',
'PhabricatorCustomFieldDataNotAvailableException' => 'infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php',
- 'PhabricatorCustomFieldImplementationIncompleteException' => 'infrastructure/customfield/exception/PhabricatorCustomFieldImplementationIncompleteException.php',
+ 'PhabricatorCustomFieldIncompleteImplementationException' => 'infrastructure/customfield/exception/PhabricatorCustomFieldIncompleteImplementationException.php',
'PhabricatorCustomFieldIndexStorage' => 'infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php',
'PhabricatorCustomFieldInterface' => 'infrastructure/customfield/interface/PhabricatorCustomFieldInterface.php',
'PhabricatorCustomFieldList' => 'infrastructure/customfield/field/PhabricatorCustomFieldList.php',
@@ -2415,19 +2415,19 @@
'PhabricatorSlugTestCase' => 'infrastructure/util/__tests__/PhabricatorSlugTestCase.php',
'PhabricatorSortTableUIExample' => 'applications/uiexample/examples/PhabricatorSortTableUIExample.php',
'PhabricatorSourceCodeView' => 'view/layout/PhabricatorSourceCodeView.php',
+ 'PhabricatorStandardBoolCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardBoolCustomField.php',
+ 'PhabricatorStandardCredentialCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardCredentialCustomField.php',
'PhabricatorStandardCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardCustomField.php',
- 'PhabricatorStandardCustomFieldBool' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php',
- 'PhabricatorStandardCustomFieldCredential' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php',
- 'PhabricatorStandardCustomFieldDate' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php',
- 'PhabricatorStandardCustomFieldHeader' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php',
- 'PhabricatorStandardCustomFieldInt' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php',
'PhabricatorStandardCustomFieldInterface' => 'infrastructure/customfield/interface/PhabricatorStandardCustomFieldInterface.php',
- 'PhabricatorStandardCustomFieldPHIDs' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php',
- 'PhabricatorStandardCustomFieldRemarkup' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php',
- 'PhabricatorStandardCustomFieldSelect' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php',
- 'PhabricatorStandardCustomFieldText' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php',
- 'PhabricatorStandardCustomFieldUsers' => 'infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php',
+ 'PhabricatorStandardDateCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardDateCustomField.php',
+ 'PhabricatorStandardHeaderCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardHeaderCustomField.php',
+ 'PhabricatorStandardIntCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardIntCustomField.php',
+ 'PhabricatorStandardPHIDsCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardPHIDsCustomField.php',
'PhabricatorStandardPageView' => 'view/page/PhabricatorStandardPageView.php',
+ 'PhabricatorStandardRemarkupCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardRemarkupCustomField.php',
+ 'PhabricatorStandardSelectCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardSelectCustomField.php',
+ 'PhabricatorStandardTextCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardTextCustomField.php',
+ 'PhabricatorStandardUsersCustomField' => 'infrastructure/customfield/standard/PhabricatorStandardUsersCustomField.php',
'PhabricatorStatusController' => 'applications/system/controller/PhabricatorStatusController.php',
'PhabricatorStatusUIExample' => 'applications/uiexample/examples/PhabricatorStatusUIExample.php',
'PhabricatorStorageFixtureScopeGuard' => 'infrastructure/testing/fixture/PhabricatorStorageFixtureScopeGuard.php',
@@ -4727,7 +4727,7 @@
'PhabricatorCursorPagedPolicyAwareQuery' => 'PhabricatorPolicyAwareQuery',
'PhabricatorCustomFieldConfigOptionType' => 'PhabricatorConfigOptionType',
'PhabricatorCustomFieldDataNotAvailableException' => 'Exception',
- 'PhabricatorCustomFieldImplementationIncompleteException' => 'Exception',
+ 'PhabricatorCustomFieldIncompleteImplementationException' => 'Exception',
'PhabricatorCustomFieldIndexStorage' => 'PhabricatorLiskDAO',
'PhabricatorCustomFieldList' => 'Phobject',
'PhabricatorCustomFieldMonogramParser' => 'Phobject',
@@ -5659,18 +5659,18 @@
'PhabricatorSlugTestCase' => 'PhabricatorTestCase',
'PhabricatorSortTableUIExample' => 'PhabricatorUIExample',
'PhabricatorSourceCodeView' => 'AphrontView',
+ 'PhabricatorStandardBoolCustomField' => 'PhabricatorStandardCustomField',
+ 'PhabricatorStandardCredentialCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorStandardCustomField' => 'PhabricatorCustomField',
- 'PhabricatorStandardCustomFieldBool' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldCredential' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldDate' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldHeader' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldInt' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldPHIDs' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldRemarkup' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldSelect' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldText' => 'PhabricatorStandardCustomField',
- 'PhabricatorStandardCustomFieldUsers' => 'PhabricatorStandardCustomFieldPHIDs',
+ 'PhabricatorStandardDateCustomField' => 'PhabricatorStandardCustomField',
+ 'PhabricatorStandardHeaderCustomField' => 'PhabricatorStandardCustomField',
+ 'PhabricatorStandardIntCustomField' => 'PhabricatorStandardCustomField',
+ 'PhabricatorStandardPHIDsCustomField' => 'PhabricatorStandardCustomField',
'PhabricatorStandardPageView' => 'PhabricatorBarePageView',
+ 'PhabricatorStandardRemarkupCustomField' => 'PhabricatorStandardCustomField',
+ 'PhabricatorStandardSelectCustomField' => 'PhabricatorStandardCustomField',
+ 'PhabricatorStandardTextCustomField' => 'PhabricatorStandardCustomField',
+ 'PhabricatorStandardUsersCustomField' => 'PhabricatorStandardPHIDsCustomField',
'PhabricatorStatusController' => 'PhabricatorController',
'PhabricatorStatusUIExample' => 'PhabricatorUIExample',
'PhabricatorStorageManagementAdjustWorkflow' => 'PhabricatorStorageManagementWorkflow',
diff --git a/src/applications/differential/customfield/DifferentialCoreCustomField.php b/src/applications/differential/customfield/DifferentialCoreCustomField.php
--- a/src/applications/differential/customfield/DifferentialCoreCustomField.php
+++ b/src/applications/differential/customfield/DifferentialCoreCustomField.php
@@ -17,7 +17,7 @@
protected function writeValueToRevision(
DifferentialRevision $revision,
$value) {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
protected function isCoreFieldRequired() {
@@ -32,7 +32,7 @@
}
protected function getCoreFieldRequiredErrorString() {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
public function validateApplicationTransactions(
diff --git a/src/applications/differential/customfield/DifferentialCustomField.php b/src/applications/differential/customfield/DifferentialCustomField.php
--- a/src/applications/differential/customfield/DifferentialCustomField.php
+++ b/src/applications/differential/customfield/DifferentialCustomField.php
@@ -203,7 +203,7 @@
if ($this->getProxy()) {
return $this->getProxy()->renderCommitMessageValue($handles);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
diff --git a/src/applications/releeph/field/specification/ReleephFieldSpecification.php b/src/applications/releeph/field/specification/ReleephFieldSpecification.php
--- a/src/applications/releeph/field/specification/ReleephFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephFieldSpecification.php
@@ -41,7 +41,7 @@
public function getRequiredStorageKey() {
$key = $this->getStorageKey();
if ($key === null) {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
if (strpos($key, '.') !== false) {
/**
@@ -183,11 +183,11 @@
}
public function renderLabelForCommitMessage() {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
public function renderValueForCommitMessage() {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
public function shouldAppearOnRevertMessage() {
@@ -222,7 +222,7 @@
}
public function getMarkupText($field) {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
final public function getMarkupEngineOutput() {
diff --git a/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php b/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
--- a/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
+++ b/src/applications/releeph/field/specification/ReleephLevelFieldSpecification.php
@@ -20,7 +20,7 @@
abstract public function getDescriptionForLevel($level);
public function getStorageKey() {
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
public function renderPropertyViewValue(array $handles) {
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldDataNotAvailableException.php
@@ -1,7 +1,6 @@
<?php
-final class PhabricatorCustomFieldDataNotAvailableException
- extends Exception {
+final class PhabricatorCustomFieldDataNotAvailableException extends Exception {
public function __construct(PhabricatorCustomField $field) {
$key = $field->getFieldKey();
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldImplementationIncompleteException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldIncompleteImplementationException.php
rename from src/infrastructure/customfield/exception/PhabricatorCustomFieldImplementationIncompleteException.php
rename to src/infrastructure/customfield/exception/PhabricatorCustomFieldIncompleteImplementationException.php
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldImplementationIncompleteException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldIncompleteImplementationException.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorCustomFieldImplementationIncompleteException
+final class PhabricatorCustomFieldIncompleteImplementationException
extends Exception {
public function __construct(
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php
@@ -1,4 +1,3 @@
<?php
-final class PhabricatorCustomFieldNotAttachedException
- extends Exception {}
+final class PhabricatorCustomFieldNotAttachedException extends Exception {}
diff --git a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php
--- a/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php
+++ b/src/infrastructure/customfield/exception/PhabricatorCustomFieldNotProxyException.php
@@ -1,7 +1,6 @@
<?php
-final class PhabricatorCustomFieldNotProxyException
- extends Exception {
+final class PhabricatorCustomFieldNotProxyException extends Exception {
public function __construct(PhabricatorCustomField $field) {
$key = $field->getFieldKey();
diff --git a/src/infrastructure/customfield/field/PhabricatorCustomField.php b/src/infrastructure/customfield/field/PhabricatorCustomField.php
--- a/src/infrastructure/customfield/field/PhabricatorCustomField.php
+++ b/src/infrastructure/customfield/field/PhabricatorCustomField.php
@@ -165,7 +165,7 @@
if ($this->proxy) {
return $this->proxy->getFieldKey();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException(
+ throw new PhabricatorCustomFieldIncompleteImplementationException(
$this,
$field_key_is_incomplete = true);
}
@@ -525,7 +525,7 @@
if ($this->proxy) {
return $this->proxy->newStorageObject();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -544,7 +544,7 @@
if ($this->proxy) {
return $this->proxy->getValueForStorage();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -568,7 +568,7 @@
if ($this->proxy) {
return $this->proxy->setValueFromStorage($value);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -652,7 +652,7 @@
*/
protected function newStringIndexStorage() {
// NOTE: This intentionally isn't proxied, to avoid call cycles.
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -666,7 +666,7 @@
*/
protected function newNumericIndexStorage() {
// NOTE: This intentionally isn't proxied, to avoid call cycles.
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -724,7 +724,7 @@
$engine,
$request);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -749,7 +749,7 @@
$query,
$value);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -776,7 +776,7 @@
$value,
$handles);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1121,7 +1121,7 @@
if ($this->proxy) {
return $this->proxy->readValueFromRequest($request);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1154,7 +1154,7 @@
if ($this->proxy) {
return $this->proxy->renderEditControl($handles);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1190,7 +1190,7 @@
if ($this->proxy) {
return $this->proxy->renderPropertyViewValue($handles);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1248,7 +1248,7 @@
if ($this->proxy) {
return $this->proxy->renderOnListItem($view);
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1299,7 +1299,7 @@
if ($this->proxy) {
return $this->proxy->getConduitDictionaryValue();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1345,7 +1345,7 @@
if ($this->proxy) {
return $this->proxy->getHeraldFieldValue();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
@@ -1359,7 +1359,7 @@
if ($this->proxy) {
return $this->proxy->getHeraldFieldConditions();
}
- throw new PhabricatorCustomFieldImplementationIncompleteException($this);
+ throw new PhabricatorCustomFieldIncompleteImplementationException($this);
}
diff --git a/src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php b/src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php
--- a/src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php
+++ b/src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php
@@ -1,7 +1,6 @@
<?php
-abstract class PhabricatorCustomFieldMonogramParser
- extends Phobject {
+abstract class PhabricatorCustomFieldMonogramParser extends Phobject {
abstract protected function getPrefixes();
abstract protected function getSuffixes();
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php b/src/infrastructure/customfield/standard/PhabricatorStandardBoolCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardBoolCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBool.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardBoolCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldBool
+final class PhabricatorStandardBoolCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php b/src/infrastructure/customfield/standard/PhabricatorStandardCredentialCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardCredentialCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldCredential.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCredentialCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldCredential
+final class PhabricatorStandardCredentialCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
@@ -1,7 +1,6 @@
<?php
-abstract class PhabricatorStandardCustomField
- extends PhabricatorCustomField {
+abstract class PhabricatorStandardCustomField extends PhabricatorCustomField {
private $rawKey;
private $fieldKey;
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php b/src/infrastructure/customfield/standard/PhabricatorStandardDateCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardDateCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardDateCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldDate
+final class PhabricatorStandardDateCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php b/src/infrastructure/customfield/standard/PhabricatorStandardHeaderCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardHeaderCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldHeader.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardHeaderCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldHeader
+final class PhabricatorStandardHeaderCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php b/src/infrastructure/customfield/standard/PhabricatorStandardIntCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardIntCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardIntCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldInt
+final class PhabricatorStandardIntCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
@@ -113,5 +113,4 @@
}
}
-
}
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php b/src/infrastructure/customfield/standard/PhabricatorStandardPHIDsCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardPHIDsCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardPHIDsCustomField.php
@@ -3,7 +3,7 @@
/**
* Common code for standard field types which store lists of PHIDs.
*/
-abstract class PhabricatorStandardCustomFieldPHIDs
+abstract class PhabricatorStandardPHIDsCustomField
extends PhabricatorStandardCustomField {
public function buildFieldIndexes() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php b/src/infrastructure/customfield/standard/PhabricatorStandardRemarkupCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardRemarkupCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardRemarkupCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldRemarkup
+final class PhabricatorStandardRemarkupCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
@@ -73,5 +73,4 @@
);
}
-
}
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php b/src/infrastructure/customfield/standard/PhabricatorStandardSelectCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardSelectCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldSelect.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardSelectCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldSelect
+final class PhabricatorStandardSelectCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php b/src/infrastructure/customfield/standard/PhabricatorStandardTextCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardTextCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldText.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardTextCustomField.php
@@ -1,6 +1,6 @@
<?php
-final class PhabricatorStandardCustomFieldText
+final class PhabricatorStandardTextCustomField
extends PhabricatorStandardCustomField {
public function getFieldType() {
diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php b/src/infrastructure/customfield/standard/PhabricatorStandardUsersCustomField.php
rename from src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php
rename to src/infrastructure/customfield/standard/PhabricatorStandardUsersCustomField.php
--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldUsers.php
+++ b/src/infrastructure/customfield/standard/PhabricatorStandardUsersCustomField.php
@@ -1,7 +1,7 @@
<?php
-final class PhabricatorStandardCustomFieldUsers
- extends PhabricatorStandardCustomFieldPHIDs {
+final class PhabricatorStandardUsersCustomField
+ extends PhabricatorStandardPHIDsCustomField {
public function getFieldType() {
return 'users';
diff --git a/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php b/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php
--- a/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php
+++ b/src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php
@@ -1,7 +1,6 @@
<?php
-abstract class PhabricatorCustomFieldIndexStorage
- extends PhabricatorLiskDAO {
+abstract class PhabricatorCustomFieldIndexStorage extends PhabricatorLiskDAO {
protected $objectPHID;
protected $indexKey;
diff --git a/src/infrastructure/customfield/storage/PhabricatorCustomFieldStorage.php b/src/infrastructure/customfield/storage/PhabricatorCustomFieldStorage.php
--- a/src/infrastructure/customfield/storage/PhabricatorCustomFieldStorage.php
+++ b/src/infrastructure/customfield/storage/PhabricatorCustomFieldStorage.php
@@ -1,7 +1,6 @@
<?php
-abstract class PhabricatorCustomFieldStorage
- extends PhabricatorLiskDAO {
+abstract class PhabricatorCustomFieldStorage extends PhabricatorLiskDAO {
protected $objectPHID;
protected $fieldIndex;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sep 12 2025, 4:12 PM (8 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
11527351
Default Alt Text
D11179.id26842.diff (27 KB)
Attached To
Mode
D11179: Rename `PhabricatorStandardCustomField` subclasses for consistency
Attached
Detach File
Event Timeline
Log In to Comment