Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14119199
D21056.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
799 B
Referenced Files
None
Subscribers
None
D21056.id.diff
View Options
diff --git a/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php b/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
--- a/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
+++ b/src/applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php
@@ -840,6 +840,13 @@
$seen[$target_identifier] = true;
+ // See PHI1688. If this commit is already marked as unreachable, we don't
+ // need to consider its ancestors. This may skip a lot of work if many
+ // branches with a lot of shared ancestry are deleted at the same time.
+ if ($target->isUnreachable()) {
+ continue;
+ }
+
try {
$stream->getCommitDate($target_identifier);
$reachable = true;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 30, 4:00 AM (14 h, 20 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6807708
Default Alt Text
D21056.id.diff (799 B)
Attached To
Mode
D21056: Improve performance when marking commits as unreachable after multiple ref deletions
Attached
Detach File
Event Timeline
Log In to Comment