Page MenuHomePhabricator
Files F14116742

D11232.diff
No OneTemporary
Actions

D11232.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -94,7 +94,6 @@
'ArcanistHgProxyServer' => 'hgdaemon/ArcanistHgProxyServer.php',
'ArcanistHgServerChannel' => 'hgdaemon/ArcanistHgServerChannel.php',
'ArcanistHookAPI' => 'repository/hookapi/ArcanistHookAPI.php',
- 'ArcanistInfrastructureTestCase' => '__tests__/ArcanistInfrastructureTestCase.php',
'ArcanistInstallCertificateWorkflow' => 'workflow/ArcanistInstallCertificateWorkflow.php',
'ArcanistJSHintLinter' => 'lint/linter/ArcanistJSHintLinter.php',
'ArcanistJSHintLinterTestCase' => 'lint/linter/__tests__/ArcanistJSHintLinterTestCase.php',
@@ -109,6 +108,7 @@
'ArcanistLesscLinter' => 'lint/linter/ArcanistLesscLinter.php',
'ArcanistLesscLinterTestCase' => 'lint/linter/__tests__/ArcanistLesscLinterTestCase.php',
'ArcanistLiberateWorkflow' => 'workflow/ArcanistLiberateWorkflow.php',
+ 'ArcanistLibraryTestCase' => '__tests__/ArcanistLibraryTestCase.php',
'ArcanistLintEngine' => 'lint/engine/ArcanistLintEngine.php',
'ArcanistLintMessage' => 'lint/ArcanistLintMessage.php',
'ArcanistLintPatcher' => 'lint/ArcanistLintPatcher.php',
@@ -286,7 +286,6 @@
'ArcanistHelpWorkflow' => 'ArcanistWorkflow',
'ArcanistHgClientChannel' => 'PhutilProtocolChannel',
'ArcanistHgServerChannel' => 'PhutilProtocolChannel',
- 'ArcanistInfrastructureTestCase' => 'ArcanistTestCase',
'ArcanistInstallCertificateWorkflow' => 'ArcanistWorkflow',
'ArcanistJSHintLinter' => 'ArcanistExternalLinter',
'ArcanistJSHintLinterTestCase' => 'ArcanistExternalLinterTestCase',
@@ -301,6 +300,7 @@
'ArcanistLesscLinter' => 'ArcanistExternalLinter',
'ArcanistLesscLinterTestCase' => 'ArcanistExternalLinterTestCase',
'ArcanistLiberateWorkflow' => 'ArcanistWorkflow',
+ 'ArcanistLibraryTestCase' => 'PhutilLibraryTestCase',
'ArcanistLintWorkflow' => 'ArcanistWorkflow',
'ArcanistLinterTestCase' => 'ArcanistPhutilTestCase',
'ArcanistLintersWorkflow' => 'ArcanistWorkflow',
diff --git a/src/__tests__/ArcanistInfrastructureTestCase.php b/src/__tests__/ArcanistInfrastructureTestCase.php
deleted file mode 100644
--- a/src/__tests__/ArcanistInfrastructureTestCase.php
+++ /dev/null
@@ -1,37 +0,0 @@
-<?php
-
-final class ArcanistInfrastructureTestCase extends ArcanistTestCase {
-
- /**
- * This is more of an acceptance test case instead of a unit test. It verifies
- * that all symbols can be loaded correctly. It can catch problems like
- * missing methods in descendants of abstract base classes.
- */
- public function testEverythingImplemented() {
- id(new PhutilSymbolLoader())->selectAndLoadSymbols();
- $this->assertTrue(true);
- }
-
- /**
- * This is more of an acceptance test case instead of a unit test. It verifies
- * that all the library map is up-to-date.
- */
- public function testLibraryMap() {
- $library = phutil_get_current_library_name();
- $root = phutil_get_library_root($library);
-
- $new_library_map = id(new PhutilLibraryMapBuilder($root))
- ->buildMap();
-
- $bootloader = PhutilBootloader::getInstance();
- $old_library_map = $bootloader->getLibraryMapWithoutExtensions($library);
- unset($old_library_map[PhutilLibraryMapBuilder::LIBRARY_MAP_VERSION_KEY]);
-
- $this->assertEqual(
- $new_library_map,
- $old_library_map,
- 'The library map does not appear to be up-to-date. Try '.
- 'rebuilding the map with `arc liberate`.');
- }
-
-}
diff --git a/src/__tests__/ArcanistLibraryTestCase.php b/src/__tests__/ArcanistLibraryTestCase.php
new file mode 100644
--- /dev/null
+++ b/src/__tests__/ArcanistLibraryTestCase.php
@@ -0,0 +1,3 @@
+<?php
+
+final class ArcanistLibraryTestCase extends PhutilLibraryTestCase {}

File Metadata

Mime Type
text/plain
Expires
Fri, Nov 29, 4:36 PM (6 h, 48 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6806068
Default Alt Text
D11232.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility