Page MenuHomePhabricator

D20866.diff
No OneTemporary

D20866.diff

diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php
--- a/src/applications/differential/parser/DifferentialChangesetParser.php
+++ b/src/applications/differential/parser/DifferentialChangesetParser.php
@@ -1743,12 +1743,6 @@
if ($new_engines !== null && $old_engines !== null) {
$shared_engines = array_intersect_key($new_engines, $old_engines);
$default_engine = head_key($new_engines);
-
- foreach ($shared_engines as $key => $shared_engine) {
- if (!$shared_engine->canDiffDocuments($old_ref, $new_ref)) {
- unset($shared_engines[$key]);
- }
- }
} else if ($new_engines !== null) {
$shared_engines = $new_engines;
$default_engine = head_key($shared_engines);
@@ -1759,6 +1753,12 @@
return null;
}
+ foreach ($shared_engines as $key => $shared_engine) {
+ if (!$shared_engine->canDiffDocuments($old_ref, $new_ref)) {
+ unset($shared_engines[$key]);
+ }
+ }
+
$engine_key = $this->getDocumentEngineKey();
if (strlen($engine_key)) {
if (isset($shared_engines[$engine_key])) {

File Metadata

Mime Type
text/plain
Expires
Sun, Nov 24, 10:35 AM (10 h, 54 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6782295
Default Alt Text
D20866.diff (1 KB)

Event Timeline