Page MenuHomePhabricator

D11753.id.diff
No OneTemporary

D11753.id.diff

diff --git a/src/applications/dashboard/application/PhabricatorDashboardApplication.php b/src/applications/dashboard/application/PhabricatorDashboardApplication.php
--- a/src/applications/dashboard/application/PhabricatorDashboardApplication.php
+++ b/src/applications/dashboard/application/PhabricatorDashboardApplication.php
@@ -55,8 +55,4 @@
);
}
- public function canUninstall() {
- return false;
- }
-
}
diff --git a/src/applications/home/application/PhabricatorHomeApplication.php b/src/applications/home/application/PhabricatorHomeApplication.php
--- a/src/applications/home/application/PhabricatorHomeApplication.php
+++ b/src/applications/home/application/PhabricatorHomeApplication.php
@@ -34,10 +34,6 @@
return false;
}
- public function canUninstall() {
- return false;
- }
-
public function getApplicationOrder() {
return 9;
}
diff --git a/src/applications/meta/controller/PhabricatorApplicationUninstallController.php b/src/applications/meta/controller/PhabricatorApplicationUninstallController.php
--- a/src/applications/meta/controller/PhabricatorApplicationUninstallController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationUninstallController.php
@@ -63,10 +63,28 @@
}
} else {
if ($selected->canUninstall()) {
- $dialog->setTitle('Confirmation')
- ->appendChild(
- 'Really Uninstall '.$selected->getName().' application?')
- ->addSubmitButton('Uninstall');
+ $dialog->setTitle(pht('Really Uninstall Application?'));
+
+ if ($selected instanceof PhabricatorHomeApplication) {
+ $dialog
+ ->appendParagraph(
+ pht(
+ 'Are you absolutely certain you want to uninstall the Home '.
+ 'application?'))
+ ->appendParagraph(
+ pht(
+ 'This is very unusual and will leave you without any '.
+ 'content on the Phabricator home page. You should only '.
+ 'do this if you are certain you know what you are doing.'))
+ ->addSubmitButton(pht('Completely Break Phabricator'));
+ } else {
+ $dialog
+ ->appendParagraph(
+ pht(
+ 'Really uninstall the %s application?',
+ $selected->getName()))
+ ->addSubmitButton(pht('Uninstall'));
+ }
} else {
$dialog->setTitle('Information')
->appendChild(

File Metadata

Mime Type
text/plain
Expires
May 12 2024, 12:07 PM (4 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6291235
Default Alt Text
D11753.id.diff (2 KB)

Event Timeline