Page MenuHomePhabricator

D18563.diff
No OneTemporary

D18563.diff

diff --git a/src/applications/herald/controller/HeraldNewController.php b/src/applications/herald/controller/HeraldNewController.php
--- a/src/applications/herald/controller/HeraldNewController.php
+++ b/src/applications/herald/controller/HeraldNewController.php
@@ -194,8 +194,9 @@
->addCancelButton($cancel_uri, $cancel_text));
$form_box = id(new PHUIObjectBoxView())
+ ->setHeaderText($title)
->setFormErrors($errors)
- ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
+ ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setForm($form);
$crumbs = $this
@@ -203,12 +204,7 @@
->addTextCrumb(pht('Create Rule'))
->setBorder(true);
- $header = id(new PHUIHeaderView())
- ->setHeader($title)
- ->setHeaderIcon('fa-plus-square');
-
$view = id(new PHUITwoColumnView())
- ->setHeader($header)
->setFooter($form_box);
return $this->newPage()
diff --git a/src/applications/herald/controller/HeraldRuleController.php b/src/applications/herald/controller/HeraldRuleController.php
--- a/src/applications/herald/controller/HeraldRuleController.php
+++ b/src/applications/herald/controller/HeraldRuleController.php
@@ -241,6 +241,8 @@
$icon = $rule->getID() ? 'fa-pencil' : 'fa-plus-square';
$form_box = id(new PHUIObjectBoxView())
+ ->setHeaderText($title)
+ ->setBackground(PHUIObjectBoxView::WHITE_CONFIG)
->setFormErrors($errors)
->setForm($form);
@@ -249,12 +251,7 @@
->addTextCrumb($title)
->setBorder(true);
- $header = id(new PHUIHeaderView())
- ->setHeader($title)
- ->setHeaderIcon('fa-plus-square');
-
$view = id(new PHUITwoColumnView())
- ->setHeader($header)
->setFooter($form_box);
return $this->newPage()

File Metadata

Mime Type
text/plain
Expires
May 10 2024, 11:28 PM (9 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6284318
Default Alt Text
D18563.diff (1 KB)

Event Timeline