Namespace `dateCreated` in Maniphest query construction
ClosedPublic
Actions

Authored by epriestley on Jul 21 2014, 1:18 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T5661: Column 'dateCreated' in where clause is ambiguous

Commits

Restricted Diffusion Commit
rP9d64beeaa345: Namespace `dateCreated` in Maniphest query construction

Summary

Fixes T5661. We may now pick up a conflicting dateCreated field from an edge table join.

Test Plan

Ran a project + dateCreated filtering query, no longer got an exception.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24022.Jul 21 2014, 1:18 PM

epriestley retitled this revision from to Namespace `dateCreated` in Maniphest query construction.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: T5661: Column 'dateCreated' in where clause is ambiguous.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 21 2014, 1:18 PM

Harbormaster completed remote builds in B1805: Diff 24022.Jul 21 2014, 1:19 PM

joshuaspence accepted this revision.Jul 21 2014, 1:22 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jul 21 2014, 1:22 PM

Closed by commit rP9d64beeaa345 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

query/

ManiphestTaskQuery.php

8 lines

Diff 24025

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Namespace `dateCreated` in Maniphest query constructionClosedPublicActions