Paths

Table of Contentst

Add more columns to typeahead wire format debugging view
ClosedPublic
Actions

Authored by epriestley on Jul 11 2014, 6:00 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4420: Modernize typeahead datasources

Commits

Restricted Diffusion Commit
rP45ea88cec486: Add more columns to typeahead wire format debugging view

Summary

Fixes T4420. This isn't perfect but is one step less janky, at least.

Test Plan

Viewed debugging view at /typeahead/class/, no unlabeled columns.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23771.Jul 11 2014, 6:00 PM

epriestley retitled this revision from to Add more columns to typeahead wire format debugging view.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4420: Modernize typeahead datasources.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 11 2014, 6:00 PM

chad accepted this revision.Jul 11 2014, 6:01 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Jul 11 2014, 6:01 PM

Harbormaster completed remote builds in B1653: Diff 23771.Jul 11 2014, 6:02 PM

shipitquick

itsawesome

bwahaha

oh god

Closed by commit rP45ea88cec486 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

typeahead/

controller/

PhabricatorTypeaheadModularDatasourceController.php

19 lines

Diff 23949

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Add more columns to typeahead wire format debugging viewClosedPublicActions