Page MenuHomePhabricator
Differential D9757

Tighten Remarkup and Fontkit CSS rules in Phabricator
ClosedPublic
Actions

Authored by epriestley on Jun 27 2014, 4:24 PM.
Tags
None
Referenced Files
F14057236: D9757.diff
Sun, Nov 17, 1:33 AM
F14041812: D9757.id.diff
Mon, Nov 11, 9:49 PM
F14038087: D9757.id23428.diff
Sun, Nov 10, 9:28 PM
F14011071: D9757.id23428.diff
Thu, Oct 31, 4:38 PM
F14002041: D9757.id23428.diff
Fri, Oct 25, 2:32 PM
F13997933: D9757.diff
Thu, Oct 24, 6:53 AM
F13968736: D9757.id23428.diff
Oct 16 2024, 10:56 PM
F13968735: D9757.id.diff
Oct 16 2024, 10:56 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
Restricted Maniphest Task
T5497: CSS rules are bleeding into widgets in `{Wxxx}` rule
Commits
Restricted Diffusion Commit
rPe42e8aa61875: Tighten Remarkup and Fontkit CSS rules in Phabricator
Summary

Fixes T5497. Scope these down a little bit so they don't bleed into {W...} embeds and such.

Test Plan
  • Viewed a Legalpad document with headers, monospaced stuff, and lists. Looked the same before/after.
  • Viewed a comment with headers, monospace, and lists. Looked the same before/after.
  • Viewed a {W..} embed, now looks sane.

Screen_Shot_2014-06-27_at_9.20.39_AM.png (1×1 px, 181 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23427.Jun 27 2014, 4:24 PM
epriestley retitled this revision from to Tighten Remarkup and Fontkit CSS rules in Phabricator.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5497: CSS rules are bleeding into widgets in `{Wxxx}` rule.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 27 2014, 4:24 PM
Harbormaster completed remote builds in B1431: Diff 23427.Jun 27 2014, 4:26 PM
chad accepted this revision.Jun 27 2014, 4:31 PM
chad edited edge metadata.
chad added inline comments.
webroot/rsrc/css/phui/phui-fontkit.css
21–22

I suppose this could just be one rule.

This revision is now accepted and ready to land.Jun 27 2014, 4:31 PM
epriestley closed this revision.Jun 27 2014, 4:39 PM
epriestley updated this revision to Diff 23428.

Closed by commit rPe42e8aa61875 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
src/
infrastructure/
markup/
2 lines
webroot/
rsrc/
css/
core/
52 lines
phui/
10 lines

Diff 23428

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/css/phui/phui-fontkit.css

Loading...
Phabricator · Built by Phacility