Page MenuHomePhabricator

Remove hovercards from Feed panels on dashboards
ClosedPublic

Authored by epriestley on Jun 27 2014, 3:31 PM.
Tags
None
Referenced Files
F13179317: D9753.diff
Wed, May 8, 9:06 PM
Unknown Object (File)
Sat, May 4, 6:36 PM
Unknown Object (File)
Sat, Apr 27, 4:30 PM
Unknown Object (File)
Fri, Apr 26, 8:28 AM
Unknown Object (File)
Wed, Apr 24, 10:28 PM
Unknown Object (File)
Sun, Apr 21, 3:01 AM
Unknown Object (File)
Sun, Apr 21, 3:01 AM
Unknown Object (File)
Sun, Apr 21, 3:01 AM
Subscribers

Details

Summary

Fixes T5472.

I do imagine doing a pass on the Hovercard JS at some point to try to make them position more intelligently (I've hit a few cases where they do something silly, and we can probably fix many of them), but generally agree that this is inconsistent and questionably valuable on panels.

Test Plan
  • Moused over feed stuff in a panel, no hovercards.
  • Moused over feed stuff in Feed, got hovercards.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Remove hovercards from Feed panels on dashboards.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2014, 3:32 PM
epriestley updated this revision to Diff 23420.

Closed by commit rP49d7201873e8 (authored by @epriestley).