Page MenuHomePhabricator
Differential D9725

Allow linking to passphrase credential via remarkup
ClosedPublic
Actions

Authored by lpriestley on Jun 25 2014, 4:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 5:10 AM
Unknown Object (File)
Mon, Dec 2, 2:58 PM
Unknown Object (File)
Wed, Nov 27, 8:27 AM
Unknown Object (File)
Tue, Nov 26, 5:08 PM
Unknown Object (File)
Nov 18 2024, 9:59 PM
Unknown Object (File)
Nov 9 2024, 7:14 PM
Unknown Object (File)
Oct 19 2024, 3:17 AM
Unknown Object (File)
Oct 14 2024, 3:06 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5421: Allow linking to Passphrase items in remarkup with "K..."
Commits
Restricted Diffusion Commit
rP83cfbe7bb48d: Allow linking to passphrase credential via remarkup
Summary

Fixes T5421, add linking to passphrase credentials

Test Plan

Open task, add a comment of '{K1}' where K1 is a passphrase credential. Preview and actual comment should be link to credential with the content of credential.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lpriestley updated this revision to Diff 23346.Jun 25 2014, 4:33 PM
lpriestley retitled this revision from to Allow linking to passphrase credential via remarkup.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T5421: Allow linking to Passphrase items in remarkup with "K...".
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 25 2014, 4:33 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1384: Diff 23346.Jun 25 2014, 4:35 PM
epriestley accepted this revision.Jun 25 2014, 9:58 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 25 2014, 9:58 PM
epriestley closed this revision.Jun 25 2014, 9:59 PM
epriestley updated this revision to Diff 23371.

Closed by commit rP83cfbe7bb48d (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
passphrase/
application/
6 lines
remarkup/
19 lines

Diff 23371

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/passphrase/application/PhabricatorApplicationPassphrase.php

Loading...
View Options

src/applications/passphrase/remarkup/PassphraseRemarkupRule.php

Loading...
Phabricator · Built by Phacility