Page MenuHomePhabricator
Differential D9687

Set `device` to `false` for all pages which don't specify device readiness
ClosedPublic
Actions

Authored by epriestley on Jun 23 2014, 5:08 PM.
Tags
None
Referenced Files
F18903261: D9687.id23243.diff
Sat, Nov 8, 4:34 AM
F18811308: D9687.id23283.diff
Mon, Oct 20, 2:37 AM
F18783099: D9687.id.diff
Oct 13 2025, 3:41 AM
F18780512: D9687.diff
Oct 12 2025, 4:46 PM
F18601026: D9687.diff
Sep 13 2025, 11:20 AM
F18589455: D9687.diff
Sep 12 2025, 3:23 AM
F18483823: D9687.diff
Sep 3 2025, 4:37 PM
F18394743: D9687.diff
Aug 29 2025, 10:15 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T5446: Remove device = true from all pages
Commits
Restricted Diffusion Commit
rPca6bd2647588: Set `device` to `false` for all pages which don't specify device readiness
Summary

Ref T5446.

  • For all callsites which do not specify a value, set false explicitly.
  • Make true the default.
Test Plan

Used grep, then manually went through everything.

Diff Detail

Repository
rP Phabricator
Branch
device1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1328
Build 1328: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23243.Jun 23 2014, 5:08 PM
epriestley retitled this revision from to Set `device` to `false` for all pages which don't specify device readiness.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5446: Remove device = true from all pages.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 23 2014, 5:08 PM
Harbormaster completed remote builds in B1328: Diff 23243.Jun 23 2014, 5:09 PM
chad accepted this revision.Jun 23 2014, 8:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2014, 8:35 PM
epriestley closed this revision.Jun 23 2014, 10:15 PM
epriestley updated this revision to Diff 23283.

Closed by commit rPca6bd2647588 (authored by @epriestley).

Revision Contents
Changeset List

Diff 23243

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonCombinedLogController.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonLogEventViewController.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBranchTableController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionChangeController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLintController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionTagListController.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactChartController.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactHomeController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestBatchEditController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationStatusController.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchHovercardController.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
Phabricator · Built by Phacility