Paths

Table of Contentst

Differential D9687

Set `device` to `false` for all pages which don't specify device readiness
ClosedPublic
Actions

Authored by epriestley on Jun 23 2014, 5:08 PM.

Details

Reviewers

chad

Maniphest Tasks

T5446: Remove device = true from all pages

Commits

Restricted Diffusion Commit
rPca6bd2647588: Set `device` to `false` for all pages which don't specify device readiness

Summary

Ref T5446.

For all callsites which do not specify a value, set false explicitly.
Make true the default.

Test Plan

Used grep, then manually went through everything.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23243.Jun 23 2014, 5:08 PM

epriestley retitled this revision from to Set `device` to `false` for all pages which don't specify device readiness.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T5446: Remove device = true from all pages.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 23 2014, 5:08 PM

Harbormaster completed remote builds in B1328: Diff 23243.Jun 23 2014, 5:09 PM

chad accepted this revision.Jun 23 2014, 8:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2014, 8:35 PM

Closed by commit rPca6bd2647588 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorController.php

2 lines

daemon/

controller/

PhabricatorDaemonCombinedLogController.php

1 line

PhabricatorDaemonConsoleController.php

1 line

PhabricatorDaemonLogEventViewController.php

1 line

PhabricatorDaemonLogViewController.php

1 line

differential/

controller/

DifferentialChangesetViewController.php

1 line

diffusion/

controller/

DiffusionBranchTableController.php

1 line

DiffusionBrowseFileController.php

1 line

DiffusionChangeController.php

1 line

DiffusionCommitController.php

2 lines

DiffusionLintController.php

1 line

DiffusionTagListController.php

1 line

fact/

controller/

PhabricatorFactChartController.php

1 line

PhabricatorFactHomeController.php

1 line

maniphest/

controller/

ManiphestBatchEditController.php

1 line

ManiphestReportController.php

1 line

notification/

controller/

PhabricatorNotificationStatusController.php

1 line

search/

controller/

PhabricatorSearchHovercardController.php

1 line

typeahead/

controller/

PhabricatorTypeaheadModularDatasourceController.php

1 line

Diff 23283

View Options

src/applications/base/controller/PhabricatorController.php

View Options

src/applications/daemon/controller/PhabricatorDaemonCombinedLogController.php

View Options

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

View Options

src/applications/daemon/controller/PhabricatorDaemonLogEventViewController.php

View Options

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

View Options

src/applications/diffusion/controller/DiffusionBranchTableController.php

View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

View Options

src/applications/diffusion/controller/DiffusionChangeController.php

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

View Options

src/applications/diffusion/controller/DiffusionLintController.php

View Options

src/applications/diffusion/controller/DiffusionTagListController.php

View Options

src/applications/fact/controller/PhabricatorFactChartController.php

View Options

src/applications/fact/controller/PhabricatorFactHomeController.php

View Options

src/applications/maniphest/controller/ManiphestBatchEditController.php

View Options

src/applications/maniphest/controller/ManiphestReportController.php

View Options

src/applications/notification/controller/PhabricatorNotificationStatusController.php

View Options

src/applications/search/controller/PhabricatorSearchHovercardController.php

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Set `device` to `false` for all pages which don't specify device readinessClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23283

src/applications/base/controller/PhabricatorController.php

src/applications/daemon/controller/PhabricatorDaemonCombinedLogController.php

src/applications/daemon/controller/PhabricatorDaemonConsoleController.php

src/applications/daemon/controller/PhabricatorDaemonLogEventViewController.php

src/applications/daemon/controller/PhabricatorDaemonLogViewController.php

src/applications/differential/controller/DifferentialChangesetViewController.php

src/applications/diffusion/controller/DiffusionBranchTableController.php

src/applications/diffusion/controller/DiffusionBrowseFileController.php

src/applications/diffusion/controller/DiffusionChangeController.php

src/applications/diffusion/controller/DiffusionCommitController.php

src/applications/diffusion/controller/DiffusionLintController.php

src/applications/diffusion/controller/DiffusionTagListController.php

src/applications/fact/controller/PhabricatorFactChartController.php

src/applications/fact/controller/PhabricatorFactHomeController.php

src/applications/maniphest/controller/ManiphestBatchEditController.php

src/applications/maniphest/controller/ManiphestReportController.php

src/applications/notification/controller/PhabricatorNotificationStatusController.php

src/applications/search/controller/PhabricatorSearchHovercardController.php

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Set `device` to `false` for all pages which don't specify device readiness
ClosedPublic
Actions

Revision Contents
Changeset List