Differential D9635

Tighten up Phragment routes to prevent page crashes
ClosedPublic
Actions

Authored by hach-que on Jun 20 2014, 12:45 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5418: Phragment policy controller fatals when given no arguments

Commits

Restricted Diffusion Commit
rP5013969a54b0: Tighten up Phragment routes to prevent page crashes

Summary

Fixes T5418. These routes were a little more permissive than they should have been.

Test Plan

Hit those URLs without a path, got a 404 instead.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que updated this revision to Diff 23115.Jun 20 2014, 12:45 AM

hach-que retitled this revision from to Tighten up Phragment routes to prevent page crashes.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T5418: Phragment policy controller fatals when given no arguments.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 20 2014, 12:45 AM

Herald added subscribers: hach-que, Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1254: Diff 23115.Jun 20 2014, 12:46 AM

epriestley accepted this revision.Jun 20 2014, 1:42 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 20 2014, 1:42 AM

Closed by commit rP5013969a54b0 (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

applications/

phragment/

application/

PhabricatorApplicationPhragment.php

10 lines

Diff 23118

View Options

src/applications/phragment/application/PhabricatorApplicationPhragment.php

Tighten up Phragment routes to prevent page crashesClosedPublicActions