Page MenuHomePhabricator
Differential D9610

Garbage collect daemon logs
ClosedPublic
Actions

Authored by epriestley on Jun 17 2014, 10:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 3:21 AM
Unknown Object (File)
Thu, Dec 12, 8:54 AM
Unknown Object (File)
Wed, Dec 11, 7:42 PM
Unknown Object (File)
Fri, Dec 6, 5:23 AM
Unknown Object (File)
Sun, Dec 1, 10:12 PM
Unknown Object (File)
Wed, Nov 27, 11:27 AM
Unknown Object (File)
Tue, Nov 26, 1:35 PM
Unknown Object (File)
Tue, Nov 19, 6:07 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
Commits
Restricted Diffusion Commit
rPdf3736e81e56: Garbage collect daemon logs
Summary

We already have GC for daemon log events, but not for daemon logs themselves.

Collect old daemon logs which aren't still running.

Test Plan

Ran phd debug garbage, observed old logs get cleaned up. Started some daemons, re-ran garbage, made sure they stuck around.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23034.Jun 17 2014, 10:27 PM
epriestley retitled this revision from to Garbage collect daemon logs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 17 2014, 10:27 PM
Harbormaster completed remote builds in B1195: Diff 23034.Jun 17 2014, 10:28 PM
joshuaspence accepted this revision.Jun 17 2014, 10:29 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jun 17 2014, 10:29 PM
epriestley closed this revision.Jun 17 2014, 10:33 PM
epriestley updated this revision to Diff 23037.

Closed by commit rPdf3736e81e56 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
2 lines
applications/
daemon/
garbagecollector/
PhabricatorDaemonLogEventGarbageCollector.php
PhabricatorDaemonLogGarbageCollector.php
2 lines
7 lines

Diff 23037

View Options

resources/sql/autopatches/20140617.daemonlog.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/daemon/garbagecollector/PhabricatorDaemonLogEventGarbageCollector.php

Loading...
View Options

src/applications/daemon/garbagecollector/PhabricatorDaemonLogGarbageCollector.php

Loading...
Phabricator · Built by Phacility