Drop support for parsing non-URL differential IDs from commit message.
ClosedPublic
Actions

Authored by joshuaspence on Jun 17 2014, 3:05 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCf2f5fb2508ef: Drop support for parsing non-URL differential IDs from commit message.

Summary

This has been a TODO for a few years now... no-one should be using the old-school (non-URL) syntax anymore.

Test Plan

I'm actually not sure if it's okay to drop support for this... please verify.

Diff Detail

Repository

rARC Arcanist

Branch

oldcommit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1168
Build 1168: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22987.Jun 17 2014, 3:05 AM

joshuaspence retitled this revision from to Drop support for parsing non-URL differential IDs from commit message..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 17 2014, 3:05 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1168: Diff 22987.Jun 17 2014, 3:06 AM

epriestley accepted this revision.Jun 17 2014, 11:18 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 17 2014, 11:18 AM

Closed by commit rARCf2f5fb2508ef (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

differential/

ArcanistDifferentialCommitMessage.php

25 lines

Diff 22987

View Options

src/differential/ArcanistDifferentialCommitMessage.php

Drop support for parsing non-URL differential IDs from commit message.ClosedPublicActions