See inline comments for reasoning.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPadbdea8d3f90: Update `.gitignore`.
N/A
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
- In theory, you are completely correct.
- In practice, we get pull requests if we don't put this stuff in .gitignore. This didn't seem like the most important battle to fight after a couple of them.
I'll accept this if you put a message in its place, like:
# NOTE: Thinking about adding files created by your operating system, IDE, # or text editor here? Don't! Add them to your per-user .gitignore instead.
..and we can see how that goes?
Comment Actions
Closed by commit rPadbdea8d3f90 (authored by @joshuaspence, committed by @epriestley).