Move icon inside link in ActionLink
ClosedPublic
Actions

Authored by chad on Jun 12 2014, 4:52 PM.

Tags

None

Referenced Files

	F13164942: D9503.diff
	Tue, May 7, 5:00 AM

	Unknown Object (File)
	Fri, May 3, 2:25 AM

	Unknown Object (File)
	Thu, May 2, 1:39 AM

	Unknown Object (File)
	Mon, Apr 29, 1:47 PM

	Unknown Object (File)
	Thu, Apr 25, 1:16 PM

	Unknown Object (File)
	Wed, Apr 24, 9:50 PM

	Unknown Object (File)
	Sun, Apr 21, 11:23 PM

	Unknown Object (File)
	Sun, Apr 21, 11:23 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5331: Unable to click on icons next to phriction pages

Commits

Restricted Diffusion Commit
rP5dca350e0e79: Move icon inside link in ActionLink

Summary

Moves the icon into the link

Test Plan

Tested a form (Phrequent), disabled, and regular action link

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 22762.Jun 12 2014, 4:52 PM

chad retitled this revision from to Move icon inside link in ActionLink.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 12 2014, 4:52 PM

Harbormaster completed remote builds in B1034: Diff 22762.Jun 12 2014, 4:53 PM

chad added a task: T5331: Unable to click on icons next to phriction pages.Jun 12 2014, 4:53 PM

epriestley accepted this revision.Jun 12 2014, 5:23 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 12 2014, 5:23 PM

Closed by commit rP5dca350e0e79 (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

view/

layout/

PhabricatorActionView.php

8 lines

Diff 22766

View Options

src/view/layout/PhabricatorActionView.php

Move icon inside link in ActionLinkClosedPublicActions