Move icon inside link in ActionLink
ClosedPublic
Actions

Authored by chad on Jun 12 2014, 4:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 18, 9:49 PM

	Unknown Object (File)
	May 6 2025, 1:23 AM

	Unknown Object (File)
	Apr 23 2025, 4:58 PM

	Unknown Object (File)
	Apr 23 2025, 4:57 PM

	Unknown Object (File)
	Apr 20 2025, 1:36 PM

	Unknown Object (File)
	Apr 20 2025, 10:47 AM

	Unknown Object (File)
	Apr 19 2025, 10:32 AM

	Unknown Object (File)
	Apr 14 2025, 10:08 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T5331: Unable to click on icons next to phriction pages

Commits

Restricted Diffusion Commit
rP5dca350e0e79: Move icon inside link in ActionLink

Summary

Moves the icon into the link

Test Plan

Tested a form (Phrequent), disabled, and regular action link

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 22762.Jun 12 2014, 4:52 PM

chad retitled this revision from to Move icon inside link in ActionLink.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 12 2014, 4:52 PM

Harbormaster completed remote builds in B1034: Diff 22762.Jun 12 2014, 4:53 PM

chad added a task: T5331: Unable to click on icons next to phriction pages.Jun 12 2014, 4:53 PM

epriestley accepted this revision.Jun 12 2014, 5:23 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 12 2014, 5:23 PM

Closed by commit rP5dca350e0e79 (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

view/

layout/

PhabricatorActionView.php

8 lines

Diff 22766

View Options

src/view/layout/PhabricatorActionView.php

Move icon inside link in ActionLinkClosedPublicActions