Page MenuHomePhabricator

Fix `ArcanistLesscLinter::getVersion` function.
ClosedPublic

Authored by joshuaspence on Jun 11 2014, 2:54 PM.
Tags
None
Referenced Files
F13335166: D9475.diff
Wed, Jun 19, 1:33 AM
F13302579: D9475.diff
Sat, Jun 8, 5:24 AM
F13286998: D9475.diff
Tue, Jun 4, 8:06 AM
F13274100: D9475.diff
May 31 2024, 3:17 AM
F13259822: D9475.diff
May 26 2024, 11:08 PM
F13242693: D9475.diff
May 23 2024, 3:01 AM
F13220731: D9475.diff
May 19 2024, 1:54 AM
F13202738: D9475.diff
May 14 2024, 11:04 PM
Subscribers

Details

Summary

This ArcanistLesscLinter::getCacheVersion should have been renamed to getVersion as of D8971, but wasn't updated.

Also fix the regex to properly capture version information.

Test Plan

It's pretty difficult to test this stuff.... I have an idea that I will submit a separate diff for.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence retitled this revision from to Fix `ArcanistLesscLinter::getVersion` function..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

Just bumping this because it is an easy fix and I want to clear some things from my queue.

As an aside, I was thinking that arc linters --verbose should (maybe) show the version number of all installed external linters, rather than just the configured ones.

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 6:49 PM