Paths

Table of Contentst

Differential D9473

Restore PEP8 errors.
ClosedPublic
Actions

Authored by joshuaspence on Jun 11 2014, 2:25 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC4371cd81f511: Restore PEP8 errors.

Summary

As per the TODO comment, now that .arclint is more mature, we should be able to restore PEP8 errors.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22654.Jun 11 2014, 2:25 PM

joshuaspence retitled this revision from to Restore PEP8 errors..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 11 2014, 2:25 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B995: Diff 22654.Jun 11 2014, 2:26 PM

I need to update the test cases as well.

Fix unit tests

Harbormaster completed remote builds in B996: Diff 22655.Jun 11 2014, 2:31 PM

Just bumping this as I'd like to clear some stale diffs from my queue.

epriestley accepted this revision.Jun 15 2014, 6:49 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2014, 6:49 PM

Closed by commit rARC4371cd81f511 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPEP8Linter.php

7 lines

__tests__/

pep8/

imports.lint-test

2 lines

Diff 22901

View Options

src/lint/linter/ArcanistPEP8Linter.php

View Options

src/lint/linter/tests/pep8/imports.lint-test

Restore PEP8 errors.ClosedPublicActions