Page MenuHomePhabricator
Differential D9464

Remove the `inlines` workflow
ClosedPublic
Actions

Authored by joshuaspence on Jun 11 2014, 1:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 12:22 AM
Unknown Object (File)
Sun, Dec 8, 8:42 AM
Unknown Object (File)
Thu, Dec 5, 7:18 PM
Unknown Object (File)
Sat, Nov 30, 7:14 AM
Unknown Object (File)
Fri, Nov 29, 10:13 AM
Unknown Object (File)
Thu, Nov 28, 3:45 PM
Unknown Object (File)
Fri, Nov 22, 1:42 PM
Unknown Object (File)
Thu, Nov 21, 1:02 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5112: Alternative for Deprecated API: differential.getrevisioncomments
Commits
rARCf8be9d7737d1: Remove the `inlines` workflow
Summary

Ref T5112. The arc inlines workflow no longer works because the differential.getrevisioncomments API method has been deprecated (see T2222). The command is basically useless right now.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2610
Build 2614: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22639.Jun 11 2014, 1:31 AM
joshuaspence retitled this revision from to Remove the `inlines` workflow..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5112: Alternative for Deprecated API: differential.getrevisioncomments.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 11 2014, 1:31 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B985: Diff 22639.Jun 11 2014, 1:32 AM
joshuaspence retitled this revision from Remove the `inlines` workflow. to Remove the `inlines` workflow.Sep 22 2014, 2:24 PM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 25322.Sep 22 2014, 9:45 PM

Rebase

Harbormaster completed remote builds in B2610: Diff 25322.Sep 22 2014, 9:46 PM
joshuaspence added a comment.Oct 12 2014, 10:04 PM

(Is there any reason that we are keeping the arc inlines workflow around even though it is completely broken?)

joshuaspence added a comment.Dec 30 2014, 11:41 PM

Just bumping this... I'm not sure why we are keeping this around if it is broken?

epriestley accepted this revision.Dec 30 2014, 11:42 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 11:42 PM
Closed by commit rARCf8be9d7737d1: Remove the `inlines` workflow (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 30 2014, 11:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25322

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/workflow/ArcanistInlinesWorkflow.php

Loading...
Phabricator · Built by Phacility