Allow logged-out access to individual diffs (vs revisions)
ClosedPublic
Actions

Authored by epriestley on Jun 10 2014, 1:00 PM.

Tags

None

Referenced Files

	F15418086: D9452.id22559.diff
	Thu, Mar 20, 8:48 PM

	F15417810: D9452.id.diff
	Thu, Mar 20, 6:46 PM

	F15416940: D9452.id22561.diff
	Thu, Mar 20, 2:26 PM

	F15404023: D9452.id22561.diff
	Tue, Mar 18, 5:53 AM

	F15403716: D9452.diff
	Tue, Mar 18, 4:37 AM

	F15396215: D9452.id22559.diff
	Sun, Mar 16, 12:40 PM

	F15392793: D9452.id22559.diff
	Sat, Mar 15, 5:35 PM

	F15378031: D9452.id22561.diff
	Thu, Mar 13, 12:13 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5303: Differential is set to public access (without login), but accessing diffs requires login

Commits

Restricted Diffusion Commit
rPc483877f5791: Allow logged-out access to individual diffs (vs revisions)

Summary

Fixes T5303. Individual diffs can have public access policies.

Test Plan

Viewed a public diff while logged out.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22559.Jun 10 2014, 1:00 PM

epriestley retitled this revision from to Allow logged-out access to individual diffs (vs revisions).

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5303: Differential is set to public access (without login), but accessing diffs requires login.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 10 2014, 1:00 PM

Harbormaster completed remote builds in B956: Diff 22559.Jun 10 2014, 1:01 PM

chad accepted this revision.Jun 10 2014, 2:14 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Jun 10 2014, 2:14 PM

Closed by commit rPc483877f5791 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialDiffViewController.php

4 lines

Diff 22561

View Options

src/applications/differential/controller/DifferentialDiffViewController.php

Allow logged-out access to individual diffs (vs revisions)ClosedPublicActions