diff --git a/src/applications/fact/application/PhabricatorApplicationFact.php b/src/applications/fact/application/PhabricatorApplicationFact.php --- a/src/applications/fact/application/PhabricatorApplicationFact.php +++ b/src/applications/fact/application/PhabricatorApplicationFact.php @@ -6,6 +6,10 @@ return 'Analyze Data'; } + public function getName() { + return pht('Facts'); + } + public function getBaseURI() { return '/fact/'; } diff --git a/src/applications/fact/controller/PhabricatorFactChartController.php b/src/applications/fact/controller/PhabricatorFactChartController.php --- a/src/applications/fact/controller/PhabricatorFactChartController.php +++ b/src/applications/fact/controller/PhabricatorFactChartController.php @@ -80,8 +80,14 @@ $panel->setHeader('Count of '.$spec->getName()); $panel->appendChild($chart); - return $this->buildStandardPageResponse( - $panel, + $crumbs = $this->buildApplicationCrumbs(); + $crumbs->addTextCrumb(pht('Chart')); + + return $this->buildApplicationPage( + array( + $crumbs, + $panel, + ), array( 'title' => 'Chart', )); diff --git a/src/applications/fact/controller/PhabricatorFactController.php b/src/applications/fact/controller/PhabricatorFactController.php --- a/src/applications/fact/controller/PhabricatorFactController.php +++ b/src/applications/fact/controller/PhabricatorFactController.php @@ -2,17 +2,4 @@ abstract class PhabricatorFactController extends PhabricatorController { - public function buildStandardPageResponse($view, array $data) { - $page = $this->buildStandardPageView(); - - $page->setBaseURI('/fact/'); - $page->setTitle(idx($data, 'title')); - - $page->setGlyph("\xCE\xA3"); - $page->appendChild($view); - - $response = new AphrontWebpageResponse(); - return $response->setContent($page->render()); - } - } diff --git a/src/applications/fact/controller/PhabricatorFactHomeController.php b/src/applications/fact/controller/PhabricatorFactHomeController.php --- a/src/applications/fact/controller/PhabricatorFactHomeController.php +++ b/src/applications/fact/controller/PhabricatorFactHomeController.php @@ -2,6 +2,10 @@ final class PhabricatorFactHomeController extends PhabricatorFactController { + public function shouldAllowPublic() { + return true; + } + public function processRequest() { $request = $this->getRequest(); $user = $request->getUser(); @@ -53,13 +57,17 @@ $chart_form = $this->buildChartForm(); - return $this->buildStandardPageResponse( + $crumbs = $this->buildApplicationCrumbs(); + $crumbs->addTextCrumb(pht('Home')); + + return $this->buildApplicationPage( array( + $crumbs, $chart_form, $panel, ), array( - 'title' => 'Facts!', + 'title' => 'Facts', )); }