Page MenuHomePhabricator
Differential D9136

Move activity log rendering to a dashboard panel
ClosedPublic
Actions

Authored by epriestley on May 15 2014, 4:58 PM.
Tags
None
Referenced Files
F14055380: D9136.diff
Sat, Nov 16, 11:09 AM
F14043495: D9136.diff
Tue, Nov 12, 10:35 AM
F14040476: D9136.id21704.diff
Mon, Nov 11, 10:29 AM
F14040475: D9136.id21723.diff
Mon, Nov 11, 10:29 AM
F14035855: D9136.id21704.diff
Sun, Nov 10, 7:47 AM
F14028141: D9136.diff
Fri, Nov 8, 11:59 AM
F14015976: D9136.diff
Mon, Nov 4, 3:42 AM
F14010087: D9136.id21704.diff
Thu, Oct 31, 4:43 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4986: Implement new Dashboard panel types
Commits
Restricted Diffusion Commit
rPe6f6a58f93c1: Move activity log rendering to a dashboard panel
Summary

Ref T4986. Swap this in. Two minor notes:

  • I adjusted the SearchEngine to add an additional constraint when the viewer isn't an admin. This mostly stops us from doing a bunch of unnecessary work.
  • I fixed the settings panel to paginate (currently loads all results, slow in production).
Test Plan

Viewed logs; viewed settings panel; created a dashboard panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21704.May 15 2014, 4:58 PM
epriestley retitled this revision from to Move activity log rendering to a dashboard panel.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4986: Implement new Dashboard panel types.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 15 2014, 4:58 PM
Harbormaster completed remote builds in B487: Diff 21704.May 15 2014, 4:59 PM
btrahan accepted this revision.May 15 2014, 7:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 15 2014, 7:43 PM
epriestley closed this revision.May 16 2014, 2:17 AM
epriestley updated this revision to Diff 21723.

Closed by commit rPe6f6a58f93c1 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
32 lines
query/
48 lines
settings/
panel/
11 lines

Diff 21723

View Options

src/applications/people/controller/PhabricatorPeopleLogsController.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleLogSearchEngine.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelActivity.php

Loading...
Phabricator · Built by Phacility