Page MenuHomePhabricator
Differential D9114

Move `getPEP8WithTextOptions` method into `ComprehensiveLintEngine` class.
ClosedPublic
Actions

Authored by joshuaspence on May 14 2014, 4:16 AM.
Tags
None
Referenced Files
F15481441: D9114.id.diff
Tue, Apr 8, 8:44 PM
F15481116: D9114.id21753.diff
Tue, Apr 8, 6:18 PM
F15479949: D9114.id21655.diff
Tue, Apr 8, 10:24 AM
F15476853: D9114.diff
Mon, Apr 7, 9:52 AM
F15443332: D9114.diff
Thu, Mar 27, 3:47 AM
F15402929: D9114.diff
Tue, Mar 18, 1:06 AM
F15394791: D9114.diff
Sun, Mar 16, 1:14 AM
F15393823: D9114.id21753.diff
Sat, Mar 15, 11:08 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC38eda3e86bb3: Move `getPEP8WithTextOptions` method into `ComprehensiveLintEngine` class.
Summary

Since this method is only used within this class, it makes sense to move it here.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21655.May 14 2014, 4:16 AM
joshuaspence retitled this revision from to Move `getPEP8WithTextOptions` method into `ComprehensiveLintEngine` class..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 14 2014, 4:16 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B454: Diff 21655.May 14 2014, 4:17 AM
epriestley edited edge metadata.May 17 2014, 2:18 AM

D3882 explicitly moved this up after accept, but I don't know why. I assume it was just a generality thing since .arclint and similar were nowehere in sight.

epriestley accepted this revision.May 17 2014, 2:18 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2014, 2:18 AM
epriestley closed this revision.May 17 2014, 2:18 AM
epriestley updated this revision to Diff 21753.

Closed by commit rARC38eda3e86bb3 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lint/
engine/
9 lines
9 lines

Diff 21753

View Options

src/lint/engine/ArcanistLintEngine.php

Loading...
View Options

src/lint/engine/ComprehensiveLintEngine.php

Loading...
Phabricator · Built by Phacility