Page MenuHomePhabricator
Differential D9099

Remove `commit` from DiffusionRequest
ClosedPublic
Actions

Authored by epriestley on May 13 2014, 2:08 PM.
Tags
None
Referenced Files
F15513564: D9099.diff
Thu, Apr 17, 7:54 PM
F15454194: D9099.diff
Mar 29 2025, 4:54 PM
F15440254: D9099.diff
Mar 26 2025, 11:41 AM
F15421427: D9099.id21611.diff
Mar 21 2025, 11:40 PM
F15415492: D9099.id21635.diff
Mar 20 2025, 6:13 AM
F15411717: D9099.id.diff
Mar 19 2025, 9:33 AM
F15411458: D9099.diff
Mar 19 2025, 9:18 AM
F15394229: D9099.diff
Mar 15 2025, 11:22 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2683: Improve the performance of Diffusion browse views
Commits
Restricted Diffusion Commit
rP23ada21d3552: Remove `commit` from DiffusionRequest
Summary

Ref T2683. This field is almost entirely redundant with symbolicCommit. Improve how some of the diff query stuff works a bit, then remove it.

Test Plan

Browsed around in all interfaces, looked at a bunch of diffs, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21611.May 13 2014, 2:08 PM
epriestley retitled this revision from to Remove `commit` from DiffusionRequest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2683: Improve the performance of Diffusion browse views.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 13 2014, 2:08 PM
Harbormaster completed remote builds in B431: Diff 21611.May 13 2014, 2:09 PM
btrahan accepted this revision.May 13 2014, 4:50 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/diffusion/conduit/ConduitAPI_diffusion_diffquery_Method.php
202–205

Hazzah!

src/applications/diffusion/controller/DiffusionHistoryController.php
155

D9091 again maybe?

This revision is now accepted and ready to land.May 13 2014, 4:50 PM
epriestley added inline comments.May 13 2014, 4:51 PM
src/applications/diffusion/controller/DiffusionHistoryController.php
155

Yeah this might be a rebase that didn't stick.

epriestley closed this revision.May 13 2014, 8:53 PM
epriestley updated this revision to Diff 21635.

Closed by commit rP23ada21d3552 (authored by @epriestley).

Revision Contents
Changeset List

Diff 21635

View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_diffquery_Method.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionChangeController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionDiffController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/query/rawdiff/DiffusionGitRawDiffQuery.php

Loading...
View Options

src/applications/diffusion/query/rawdiff/DiffusionMercurialRawDiffQuery.php

Loading...
View Options

src/applications/diffusion/query/rawdiff/DiffusionRawDiffQuery.php

Loading...
View Options

src/applications/diffusion/query/rawdiff/DiffusionSvnRawDiffQuery.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
Phabricator · Built by Phacility