Remove `shouldCreateDiffusionRequest` from Diffusion conduit methods
ClosedPublic
Actions

Authored by epriestley on May 13 2014, 12:08 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2683: Improve the performance of Diffusion browse views

Commits

Restricted Diffusion Commit
rP7cc9720d6096: Remove `shouldCreateDiffusionRequest` from Diffusion conduit methods

Summary

Ref T2683. This has no callsites, and the functionality is covered by the initFromConduit flag.

This simplifies the code and reduces then number of internal diffusion.resolverefs calls we make on, e.g., the Git repository page from 7 to 2.

Test Plan

Grepped for these symbols.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21598.May 13 2014, 12:08 PM

epriestley retitled this revision from to Remove `shouldCreateDiffusionRequest` from Diffusion conduit methods.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2683: Improve the performance of Diffusion browse views.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 13 2014, 12:08 PM

Harbormaster completed remote builds in B420: Diff 21598.May 13 2014, 12:09 PM

long live initFromConduit

This revision is now accepted and ready to land.May 13 2014, 4:07 PM

Closed by commit rP7cc9720d6096 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

ConduitAPI_diffusion_abstractquery_Method.php

73 lines

Diff 21629

View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php

Remove `shouldCreateDiffusionRequest` from Diffusion conduit methodsClosedPublicActions