Page MenuHomePhabricator
Differential D9083

Support Checkstyle as an output format for lint results.
ClosedPublic
Actions

Authored by joshuaspence on May 12 2014, 10:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:54 AM
Unknown Object (File)
Sun, Nov 17, 4:06 PM
Unknown Object (File)
Thu, Nov 14, 6:28 AM
Unknown Object (File)
Sat, Nov 9, 4:43 PM
Unknown Object (File)
Oct 23 2024, 2:05 PM
Unknown Object (File)
Oct 23 2024, 2:01 PM
Unknown Object (File)
Oct 23 2024, 10:33 AM
Unknown Object (File)
Oct 22 2024, 7:43 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4948: Support checkstyle as an output format
Commits
rARCec3de41684c9: Support Checkstyle as an output format for lint results.
Summary

Fixes T4948. Add a lint renderer which supports outputting the lint results in the Checkstyle XML format.

Test Plan

Ran arc lint --xml and inspected the output.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21586.May 12 2014, 10:09 PM
joshuaspence retitled this revision from to Support Checkstyle as an output format for lint results..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T4948: Support checkstyle as an output format.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2014, 10:09 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence added a comment.May 12 2014, 10:09 PM

This is currently a bit too hacky for my liking, but I wanted to get some initial feedback before I pursue this any further.

Harbormaster completed remote builds in B410: Diff 21586.May 12 2014, 10:10 PM
joshuaspence updated this revision to Diff 21596.May 13 2014, 8:59 AM
joshuaspence edited edge metadata.

Rewrote this to be less of a hack. It probably still needs improvement, but I think this is an improvement.

Harbormaster completed remote builds in B418: Diff 21596.May 13 2014, 9:00 AM
joshuaspence added a comment.May 13 2014, 9:10 AM

Although I imagine this may have a large memory footprint when used with arc lint --everything.

joshuaspence updated this revision to Diff 21603.May 13 2014, 12:34 PM

Use XMLWriter instead of SimpleXMLElement.

Harbormaster completed remote builds in B425: Diff 21603.May 13 2014, 12:35 PM
epriestley accepted this revision.May 13 2014, 8:20 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/lint/renderer/ArcanistLintRenderer.php
13

I'm not so sure about this method name.

This revision is now accepted and ready to land.May 13 2014, 8:20 PM
epriestley closed this revision.May 13 2014, 8:20 PM
epriestley updated this revision to Diff 21627.

Closed by commit rARCec3de41684c9 (authored by @joshuaspence, committed by @epriestley).

joshuaspence added inline comments.May 13 2014, 9:46 PM
src/lint/renderer/ArcanistLintRenderer.php
13

Me either.

Revision Contents
Changeset List

Diff 21627

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/renderer/ArcanistLintCheckstyleXMLRenderer.php

Loading...
View Options

src/lint/renderer/ArcanistLintRenderer.php

Loading...
View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility