Use `k in map`, not `array.indexOf`, in Event.js
ClosedPublic
Actions

Authored by epriestley on May 12 2014, 9:28 PM.

Tags

None

Referenced Files

	F18349420: D9082.diff
	Tue, Aug 26, 6:15 PM

	F18106043: D9082.id21584.diff
	Sun, Aug 10, 8:59 PM

	F18105874: D9082.id.diff
	Sun, Aug 10, 8:09 PM

	F18104578: D9082.id21585.diff
	Sun, Aug 10, 1:18 PM

	F18099207: D9082.diff
	Sat, Aug 9, 2:46 AM

	F18091629: D9082.id21585.diff
	Wed, Aug 6, 11:56 PM

	F18088807: D9082.id.diff
	Wed, Aug 6, 9:36 AM

	Unknown Object (File)
	Jul 3 2025, 10:48 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T5023: Unable to drag/reorder tasks in any version of IE

Commits

Restricted Diffusion Commit
rP91eb751d6f3d: Use `k in map`, not `array.indexOf`, in Event.js

Summary

See T5023.

Test Plan

Dragged stuff.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21584.May 12 2014, 9:28 PM

epriestley retitled this revision from to Use `k in map`, not `array.indexOf`, in Event.js.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2014, 9:28 PM

btrahan accepted this revision.May 12 2014, 9:28 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 12 2014, 9:28 PM

Harbormaster completed remote builds in B409: Diff 21584.May 12 2014, 9:29 PM

Closed by commit rP91eb751d6f3d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

webroot/

rsrc/

externals/

javelin/

core/

Event.js

5 lines

Diff 21585

View Options

resources/celerity/map.php