Page MenuHomePhabricator

Warn when accessing deprecated lint config
ClosedPublic

Authored by epriestley on May 11 2014, 11:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 7:00 AM
Unknown Object (File)
Sun, Nov 17, 1:01 PM
Unknown Object (File)
Mon, Nov 11, 9:54 PM
Unknown Object (File)
Tue, Nov 5, 7:08 PM
Unknown Object (File)
Sat, Nov 2, 8:06 PM
Unknown Object (File)
Thu, Oct 31, 4:56 AM
Unknown Object (File)
Thu, Oct 31, 4:39 AM
Unknown Object (File)
Wed, Oct 30, 9:45 PM
Subscribers

Details

Reviewers
joshuaspence
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
rARC7870e7f2e46d: Warn when accessing deprecated lint config
Summary

Ref T2039. Addresses two issues:

  • Issues a warning for use of config which is deprecated by .arclint.
  • We no longer require an engine to be present for these linters, so arc linters doesn't fatal if they aren't configured.
Test Plan
  • Ran arc linters in a repo with no JSHint.
  • Ran arc linters in a repo with junk in .arcconfig and got a warning when it was read. Verified it still took effect.

Diff Detail

Repository
rARC Arcanist
Branch
lintdeprecate
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 370
Build 370: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestFlake8Lint
0 mstestJSHintLinter
0 mstestCSSLintLinter
0 mstestFixLetterCase
0 mstestLintPath
View Full Test Results (2 Failed · 11 Passed · 4 Skipped)

Event Timeline

epriestley retitled this revision from to Warn when accessing deprecated lint config.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
epriestley added a task: Restricted Maniphest Task.
joshuaspence edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.May 11 2014, 11:45 PM
epriestley updated this revision to Diff 21513.

Closed by commit rARC7870e7f2e46d (authored by @epriestley).