Differential D9048

Slightly reduce the cost of resolving refs
ClosedPublic
Actions

Authored by epriestley on May 11 2014, 12:46 AM.

Details

Reviewers

btrahan

Maniphest Tasks

T2683: Improve the performance of Diffusion browse views

Commits

Restricted Diffusion Commit
rP53e9df8a0282: Slightly reduce the cost of resolving refs

Summary

Ref T2683. By resolving the stable name earlier, we can save a resolve when viewing branch heads. This is ~100ms in Mercurial, and roughly 25% of page weight. It's less bad in Git.

Test Plan

Saw page cost go down in "Services" tab, particularly for Mercurial browse views.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21489.May 11 2014, 12:46 AM

epriestley retitled this revision from to Slightly reduce the cost of resolving refs.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2683: Improve the performance of Diffusion browse views.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 11 2014, 12:46 AM

Harbormaster completed remote builds in B357: Diff 21489.May 11 2014, 12:47 AM

btrahan accepted this revision.May 12 2014, 6:28 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 12 2014, 6:28 PM

Closed by commit rP53e9df8a0282 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseMainController.php

2 lines

Diff 21573

View Options

src/applications/diffusion/controller/DiffusionBrowseMainController.php

Slightly reduce the cost of resolving refsClosedPublicActions