Page MenuHomePhabricator

Slightly reduce the cost of resolving refs
ClosedPublic

Authored by epriestley on May 11 2014, 12:46 AM.
Tags
None
Referenced Files
F14055406: D9048.diff
Sat, Nov 16, 11:33 AM
F14042697: D9048.diff
Tue, Nov 12, 5:22 AM
F14033423: D9048.id21573.diff
Sat, Nov 9, 5:38 PM
F14033422: D9048.id21489.diff
Sat, Nov 9, 5:38 PM
F14033421: D9048.id.diff
Sat, Nov 9, 5:37 PM
F14026339: D9048.diff
Fri, Nov 8, 1:03 AM
F14020558: D9048.diff
Wed, Nov 6, 12:44 AM
F13989838: D9048.id21489.diff
Mon, Oct 21, 11:25 PM
Subscribers

Details

Summary

Ref T2683. By resolving the stable name earlier, we can save a resolve when viewing branch heads. This is ~100ms in Mercurial, and roughly 25% of page weight. It's less bad in Git.

Test Plan

Saw page cost go down in "Services" tab, particularly for Mercurial browse views.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Slightly reduce the cost of resolving refs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 6:28 PM
epriestley updated this revision to Diff 21573.

Closed by commit rP53e9df8a0282 (authored by @epriestley).