Page MenuHomePhabricator

Allow linters that extend `ArcanistExternalLinter` to customize the file parameter
ClosedPublic

Authored by champo on May 9 2014, 4:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 8:14 AM
Unknown Object (File)
Feb 14 2024, 8:51 PM
Unknown Object (File)
Feb 2 2024, 5:30 AM
Unknown Object (File)
Jan 19 2024, 4:51 PM
Unknown Object (File)
Jan 15 2024, 5:20 PM
Unknown Object (File)
Jan 13 2024, 8:28 AM
Unknown Object (File)
Jan 7 2024, 5:01 PM
Unknown Object (File)
Jan 7 2024, 8:54 AM
Subscribers

Details

Summary

Not all linters run on a command file fashion. In particular, the maven checkstyle plugin runs like command --flag=file.

Test Plan

Run a linter that extends ArcanistExternalLinter.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

champo retitled this revision from to Allow linters that extend `ArcanistExternalLinter` to override the future.
champo updated this object.
champo edited the test plan for this revision. (Show Details)
champo added a reviewer: epriestley.

Sorry for the ninja diff, I was coding, got into it and forgot to log into IRC to check with you. We don't need this upstream 100% but it would be nice.

Hmm, let's add some kind of, like getPathArgumentForLinterFuture($path) instead, which defaults to return $path;? I'd rather not expose the entire future construction unless we have to. Subclasses might have difficulty implementing subtleties like stdin rules and eventual hook rules correctly, and this stuff could change later.

Yeah, that sounds better.

champo edited edge metadata.

Instead of overriding the future, add a method to customize the file parameter.

champo retitled this revision from Allow linters that extend `ArcanistExternalLinter` to override the future to Allow linters that extend `ArcanistExternalLinter` to customize the file parameter.May 11 2014, 12:09 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 11 2014, 11:25 PM
epriestley updated this revision to Diff 21506.

Closed by commit rARC377c585752b6 (authored by @champo, committed by @epriestley).