Not all linters run on a command file fashion. In particular, the maven checkstyle plugin runs like command --flag=file.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC377c585752b6: Allow linters that extend `ArcanistExternalLinter` to customize the file…
Run a linter that extends ArcanistExternalLinter.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Sorry for the ninja diff, I was coding, got into it and forgot to log into IRC to check with you. We don't need this upstream 100% but it would be nice.
Comment Actions
Hmm, let's add some kind of, like getPathArgumentForLinterFuture($path) instead, which defaults to return $path;? I'd rather not expose the entire future construction unless we have to. Subclasses might have difficulty implementing subtleties like stdin rules and eventual hook rules correctly, and this stuff could change later.