Paths

Table of Contentst

Reduce method visibility.
ClosedPublic
Actions

Authored by joshuaspence on May 6 2014, 3:28 AM.

Tags

None

Referenced Files

	F15507880: D8991.id21348.diff
	Tue, Apr 15, 11:41 PM

	F15505959: D8991.id.diff
	Tue, Apr 15, 7:18 AM

	F15503175: D8991.diff
	Mon, Apr 14, 7:37 AM

	F15472347: D8991.diff
	Sat, Apr 5, 12:46 PM

	F15461089: D8991.id21348.diff
	Tue, Apr 1, 5:07 AM

	F15429171: D8991.id21349.diff
	Mar 24 2025, 1:01 AM

	F15415725: D8991.diff
	Mar 20 2025, 7:40 AM

	F15409390: D8991.id21349.diff
	Mar 19 2025, 4:28 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC48d52c30b07a: Reduce method visibility.

Summary

These methods are declared public, but there are meant to be protected (as they are declared in ArcanistExternalLinter).

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21348.May 6 2014, 3:28 AM

joshuaspence retitled this revision from to Reduce method visibility..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2014, 3:28 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B264: Diff 21348.May 6 2014, 3:29 AM

epriestley accepted this revision.May 6 2014, 3:31 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 6 2014, 3:31 AM

Closed by commit rARC48d52c30b07a (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistJSHintLinter.php

4 lines

Diff 21349

View Options

src/lint/linter/ArcanistJSHintLinter.php

Reduce method visibility.ClosedPublicActions