Make tokens more accessible to assitive technologies
ClosedPublic
Actions

Authored by epriestley on May 5 2014, 4:48 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4843: Making Phabricator accessible to assistive technologies

Commits

Restricted Diffusion Commit
rP9b66f00484da: Make tokens more accessible to assitive technologies

Summary

Ref T4843.

The token award buttons are just icons.
The tokens themselves are just icons.
Also spread the tokens out a tiny bit, they feel a little tight to me right now.

Test Plan

Used VoiceOver to read out tokens and token actions. Looked at an object with several token awards.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21307.May 5 2014, 4:48 PM

epriestley retitled this revision from to Make tokens more accessible to assitive technologies.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T4843: Making Phabricator accessible to assistive technologies.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 5 2014, 4:48 PM

Harbormaster completed remote builds in B249: Diff 21307.May 5 2014, 4:49 PM

btrahan accepted this revision.May 5 2014, 4:51 PM

btrahan edited edge metadata.

btrahan added inline comments.

webroot/rsrc/css/application/tokens/tokens.css
22	what's the '+' do?

This revision is now accepted and ready to land.May 5 2014, 4:51 PM

The + is an adjacent element selector, so this makes us "implode" the list with space (it only applies to tokens which immediately follow another token in the document), rather than ending up with a weird 4px margin at the beginning or end.