Page MenuHomePhabricator
Differential D8957

Add a quote action to Differential and Maniphest
ClosedPublic
Actions

Authored by epriestley on May 2 2014, 6:57 PM.

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4119: Button to automatically copy & quote text
Commits
Restricted Diffusion Commit
rP707c5aec8138: Add a quote action to Differential and Maniphest
Summary

Ref T4119. This is ugly for now, but technically works.

The comment area and transaction log don't realy know about each other, so for the moment the linking is a bit manual. Differential/Maniphest are special cases anyway.

Test Plan

Screen_Shot_2014-05-02_at_11.50.22_AM.png (617×1 px, 74 KB)

Diff Detail

Repository
rP Phabricator
Branch
rm7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 206
Build 206: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21250.May 2 2014, 6:57 PM
epriestley retitled this revision from to Add a quote action to Differential and Maniphest.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T4119: Button to automatically copy & quote text.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 2 2014, 6:57 PM
Harbormaster completed remote builds in B206: Diff 21250.May 2 2014, 6:59 PM
btrahan accepted this revision.May 2 2014, 7:12 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 2 2014, 7:12 PM
epriestley closed this revision.May 5 2014, 5:56 PM
epriestley updated this revision to Diff 21317.

Closed by commit rP707c5aec8138 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
37 lines
src/
2 lines
applications/
differential/
controller/
8 lines
maniphest/
controller/
2 lines
transactions/
application/
2 lines
controller/
67 lines
view/
31 lines
view/
phui/
45 lines
webroot/
rsrc/
js/
application/
transactions/
32 lines

Diff 21250

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/transactions/application/PhabricatorApplicationTransactions.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentQuoteController.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
View Options

webroot/rsrc/js/application/transactions/behavior-transaction-list.js

Loading...
Phabricator · Built by Phacility