Page MenuHomePhabricator

Don't show document types in search for uninstalled applications
ClosedPublic

Authored by epriestley on Apr 29 2014, 9:47 PM.

Details

Summary

Fixes T4917. Currently, if a user doesn't have access to, e.g., Phriction, they still get a checkbox in the search results to search for Wiki Documents. Those results will be filtered anyway, so this is confusing at best.

Instead, bind PHID types to applications. This is a relatively tailored fix; some areas for potential future work:

  • Go through every PHID type and bind them all to applications. Vaguely nice to have, but doesn't get us anything for now.
  • If no searchable application is installed, we don't show you an error state. This isn't currently possible ("People" is always installed) but in the interest of generality we could throw an exception or something at least.
  • The elasticserach thing could probably constrain types to visible types, but we don't have a viewer there easily right now.
Test Plan

Uninstalled Phriction, saw the checkbox vanish.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't show document types in search for uninstalled applications.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2014, 9:58 PM
epriestley updated this revision to Diff 21133.

Closed by commit rP8fe27800fcec (authored by @epriestley).