Page MenuHomePhabricator

Fix strange bug for russian language search results
ClosedPublic

Authored by rugabarbo on Apr 25 2014, 1:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 9, 4:33 AM
Unknown Object (File)
Sun, Mar 31, 3:26 PM
Unknown Object (File)
Wed, Mar 27, 5:28 PM
Unknown Object (File)
Wed, Mar 27, 5:28 PM
Unknown Object (File)
Wed, Mar 27, 5:28 PM
Unknown Object (File)
Sat, Mar 23, 1:19 PM
Unknown Object (File)
Sat, Mar 23, 1:19 PM
Unknown Object (File)
Sat, Mar 23, 1:19 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP035d55f67fea: Fix strange bug for russian language search results
Summary

I created this review to get an answer...
It should not be taken as a real fix.

I noticed that phabricator return corrupted search results for some russian queries (without this patch).
See screenshot:

broken_search.png (1×2 px, 220 KB)

But I can't reproduce this bug on https://secure.phabricator.com/
This search query causes problems only for my phabricator instance.

More than that, I didn't find any php.ini-settings that can resolve this problem.
It's look like your phabricator instance use /u-modifier by default.

But how is it possible?

Test Plan

NONE

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rugabarbo retitled this revision from to Fix strange bug for russian language search results.
rugabarbo updated this object.
rugabarbo edited the test plan for this revision. (Show Details)
rugabarbo added a reviewer: epriestley.

Hmm...

This bug appears for Mac OS X Phabricator installation.
This bug doesn't appear for Ubuntu Phabricator installation.

But I really have no idea about what kind of setting it depends.

epriestley edited edge metadata.

I think this is correct, although this method is kind of sketchy in general. I might try to rewrite it so we don't need to use phutil_safe_html(). Thanks!

This revision is now accepted and ready to land.Apr 25 2014, 6:52 PM
epriestley updated this revision to Diff 21021.

Closed by commit rP035d55f67fea (authored by @rugabarbo, committed by @epriestley).