Page MenuHomePhabricator
Differential D8845

Clean up FontAwesome / Timeline CSS
ClosedPublic
Actions

Authored by chad on Apr 23 2014, 1:12 AM.
Tags
None
Referenced Files
F18557494: D8845.id.diff
Mon, Sep 8, 7:59 PM
F18513796: D8845.diff
Fri, Sep 5, 9:46 AM
F18231490: D8845.id20983.diff
Wed, Aug 20, 2:18 PM
F18220090: D8845.diff
Tue, Aug 19, 1:51 PM
F18168928: D8845.id20984.diff
Aug 15 2025, 4:24 PM
F18168924: D8845.id20983.diff
Aug 15 2025, 4:24 PM
F18054543: D8845.id20983.diff
Aug 4 2025, 6:20 AM
F18037501: D8845.diff
Aug 3 2025, 2:36 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP4135c7de372d: Clean up FontAwesome / Timeline CSS
Summary

Normalize FA CSS, expand timeline icons to 14px, fix mobile browsers, give attribution in uiexamples

Test Plan

tested iOS simulator, chrome, ie

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 20983.Apr 23 2014, 1:12 AM
chad retitled this revision from to Clean up FontAwesome / Timeline CSS.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptApr 23 2014, 1:12 AM
chad added a comment.Apr 23 2014, 1:13 AM

undefined (684×365 px, 137 KB)

Harbormaster completed remote builds in B48: Diff 20983.Apr 23 2014, 1:13 AM
epriestley accepted this revision.Apr 23 2014, 1:13 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 23 2014, 1:13 AM
chad closed this revision.Apr 23 2014, 1:29 AM
chad updated this revision to Diff 20984.

Closed by commit rP4135c7de372d (authored by @chad).

chad added a comment.Apr 23 2014, 1:29 AM

even tested windows phone, muthafucka

epriestley added a comment.Apr 23 2014, 1:30 AM

like

woah

chad added a comment.Apr 23 2014, 1:31 AM

The button was right next to emulate ie8, so not really significant

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
applications/
uiexample/
examples/
11 lines
webroot/
rsrc/
css/
application/
uiexample/
2 lines
font/
20 lines
phui/
4 lines
12 lines

Diff 20984

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIIconExample.php

Loading...
View Options

webroot/rsrc/css/application/uiexample/example.css

Loading...
View Options

webroot/rsrc/css/font/phui-font-icon-base.css

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility