Page MenuHomePhabricator

Allow Conduit console to be browsed by logged-out users
ClosedPublic

Authored by epriestley on Apr 20 2014, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 8:51 AM
Unknown Object (File)
Wed, May 1, 3:32 AM
Unknown Object (File)
Tue, Apr 30, 7:46 AM
Unknown Object (File)
Mon, Apr 29, 5:50 AM
Unknown Object (File)
Sun, Apr 28, 12:32 PM
Unknown Object (File)
Sun, Apr 28, 12:32 AM
Unknown Object (File)
Wed, Apr 24, 11:17 PM
Unknown Object (File)
Sat, Apr 20, 6:47 PM
Subscribers

Details

Summary

Ref T4830. A few methods, like conduit.ping, are callable without authentication, so this even has some use cases. Also:

  • Make some Differential stuff a little more consistent.
  • Use slightly more modern rendering.
  • Deprecate the status-oriented user calls; these will be replaced by Calendar methods.
Test Plan

Browsed console as logged out / logged in users.

Diff Detail

Repository
rP Phabricator
Branch
pub2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23
Build 23: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow Conduit console to be browsed by logged-out users.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
btrahan edited edge metadata.

I think the user status methods are used by FB to sync their status tool information into their Phabricator instance. I am not 100% positive though.

src/applications/people/conduit/ConduitAPI_user_addstatus_Method.php
3

i think the changes to these methods might break FB.

This revision is now accepted and ready to land.Apr 21 2014, 9:30 PM

They are, but deprecating methods just colors them red in the UI and removes them from the "modern queries" view. They still behave properly, so it shouldn't break anything.

epriestley updated this revision to Diff 20958.

Closed by commit rP27d426e3fe92 (authored by @epriestley).