Paths

Table of Contentst

Actually squelch Harbormaster "test passed" mail
ClosedPublic
Actions

Authored by epriestley on Apr 18 2014, 11:31 PM.

Tags

None

Referenced Files

	F13051538: D8813.id20917.diff
	Fri, Apr 19, 3:34 AM

	F13051537: D8813.id20913.diff
	Fri, Apr 19, 3:34 AM

	F13051536: D8813.id.diff
	Fri, Apr 19, 3:34 AM

	Unknown Object (File)
	Tue, Apr 16, 12:25 AM

	Unknown Object (File)
	Sun, Apr 14, 10:30 AM

	Unknown Object (File)
	Thu, Apr 11, 4:47 AM

	Unknown Object (File)
	Tue, Apr 2, 5:24 AM

	Unknown Object (File)
	Tue, Mar 26, 7:31 AM

View All Files

Subscribers

epriestley

Tokens

"Baby Tequila" token, awarded by btrahan.

Details

Reviewers

btrahan

Maniphest Tasks

T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rP9889892e5b76: Actually squelch Harbormaster "test passed" mail

Summary

Ref T1049. When Harbormaster tests pass, don't bother sending an email about it.

(I tried to implement this earlier but didn't test it entirely properly, and we needed a little more code.)

Test Plan

Used bin/harbormaster build to build some junk, got no email about passes.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20913.Apr 18 2014, 11:31 PM

epriestley retitled this revision from to Actually squelch Harbormaster "test passed" mail.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T1049: Implement Harbormaster.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2014, 11:31 PM

Harbormaster completed remote builds in B8: Diff 20913.Apr 18 2014, 11:33 PM

btrahan accepted this revision.Apr 19 2014, 12:24 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 19 2014, 12:24 AM

Closed by commit rP9889892e5b76 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialTransaction.php

2 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

15 lines

Diff 20917

View Options

src/applications/differential/storage/DifferentialTransaction.php