Page MenuHomePhabricator

Add `activeDiffPHID` to differential.query
ClosedPublic

Authored by epriestley on Apr 17 2014, 4:06 PM.

Details

Summary

Ref T4809. This saves us a few round trips to find a Buildable, and generally makes the notion of "active" more explicit (i.e., not just the diff with the largest ID). In the future, we may let you revert to previous diffs, which would make the "largest number" rule not always correct.

Test Plan

Ran differential.query, got sensible results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Add `activeDiffPHID` to differential.query.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 17 2014, 6:32 PM
epriestley updated this revision to Diff 20897.

Closed by commit rP62973e0f5396 (authored by @epriestley).