Differential D8786

Allow Harbormaster HTTP steps to pass credentials
ClosedPublic
Actions

Authored by epriestley on Apr 16 2014, 2:06 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T1049: Implement Harbormaster
T4590: Unable to pass in HTTP auth in the Build Plans->Make HTTP Request section

Commits

Restricted Diffusion Commit
rP803c50c1e7b4: Allow Harbormaster HTTP steps to pass credentials

Summary

Fixes T4590. Use the credentials custom field to allow Harbormaster HTTP requests to include usernames/passwords.

Test Plan

Ran a build plan with credentials, verified they were sent to the remote server.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20845.Apr 16 2014, 2:06 PM

epriestley retitled this revision from to Allow Harbormaster HTTP steps to pass credentials.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4590: Unable to pass in HTTP auth in the Build Plans->Make HTTP Request section.

Herald added a subscriber: epriestley.Apr 16 2014, 2:06 PM

btrahan accepted this revision.Apr 16 2014, 6:35 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 16 2014, 6:35 PM

Closed by commit rP803c50c1e7b4 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

step/

HarbormasterHTTPRequestBuildStepImplementation.php

44 lines

Diff 20862

View Options

src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php

Allow Harbormaster HTTP steps to pass credentialsClosedPublicActions