Differential D8669

Add phragment.querysnapshots method
AbandonedPublic
Actions

Authored by hach-que on Apr 2 2014, 3:05 AM.

Tags

None

Referenced Files

	F13207531: D8669.diff
	Thu, May 16, 12:50 AM

	F13206762: D8669.diff
	Wed, May 15, 5:26 PM

	F13187398: D8669.diff
	Sat, May 11, 4:30 AM

	Unknown Object (File)
	Tue, May 7, 6:35 AM

	Unknown Object (File)
	Fri, May 3, 5:57 AM

	Unknown Object (File)
	Thu, May 2, 7:07 PM

	Unknown Object (File)
	Mon, Apr 29, 4:33 PM

	Unknown Object (File)
	Sun, Apr 28, 9:30 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5479: Unbeta Phragment
T4884: At some point, review hach-que's diffs

Summary

This adds a Conduit method to query the snapshots available on a given fragment.

Test Plan

Used it, it worked.

Diff Detail

Repository

Branch

phragment-conduit-snapshot-query

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:41	PHL1	Unknown Symbol
Error	src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:49	PHL1	Unknown Symbol
Error	src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:53	PHL1	Unknown Symbol

Unit

No Test Coverage

Event Timeline

hach-que updated this revision to Diff 20557.Apr 2 2014, 3:05 AM

hach-que retitled this revision from to Add phragment.querysnapshots method.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers.Apr 2 2014, 3:05 AM

Herald added subscribers: hach-que, Korvin, epriestley.

Rebase on master

Harbormaster completed remote builds in B2125: Diff 24551.Aug 9 2014, 5:16 AM

joshuaspence added a subscriber: joshuaspence.Mar 1 2015, 7:18 AM

I'm pretty sure this needs to wait for T7715 like D8660.

Might as well abandon this as we're no longer using it in production (and is probably still years away on the upstream roadmap).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

10 lines

src/

__phutil_library_map__.php

2 lines

applications/

phragment/

conduit/

ConduitAPI_phragment_querysnapshots_Method.php

54 lines

Diff 20557

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/phragment/conduit/ConduitAPI_phragment_querysnapshots_Method.php

Loading...