Previously, you would not receive a mail message for the first comment you make on an audit, but you would for subsequent comments because everyone who's made a comment would be CCed on the email. This mirrors DifferentialTransactionEditor's getMailTo which always adds $object->getAuthorPHID().
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPdeba531401f7: Send mail to audit comment author too
With self mail turned on, made the first comment on a commit and received an email for it. With self mail turned off, commented on a different commit and saw in bin/mail list-outbound that the message was voided.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Thanks! That lint error is approximately T1486 (in this case, it's actually "symbol caches aren't dropped/dirtied when we add new functions to the extension function list"). We added these in D8280, but I'm guessing your caches predate that.
Since this arises rarely and only for developers and there isn't an obvious five-line fix, I haven't gotten around to fixing it. The best workaround at the moment is to nuke these files:
rm libphutil/src/.phutil_module_cache rm arcanist/src/.phutil_module_cache rm phabricator/src/.phutil_module_cache