Page MenuHomePhabricator

Fix Mailgun Reply-To handling
ClosedPublic

Authored by carl on Mar 29 2014, 5:50 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP213eea7bdd00: Fix Mailgun Reply-To handling
Summary

When sending the "Reply-To" header to Mailgun, Phabricator would
previously send two headers for every "Reply-To": "Reply-To[0][email]" and
"Reply-To[0][name]". Instead, explicitly build the header as specified by RFC
2822 and send it to Mailgun pre-baked.

Pretty sure this bug was a cargo-cult from the Sendgrid code, where (apparently)
this actually works.

Test Plan

Triggered an email from Phabricator, saw that the header was sent
properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

carl retitled this revision from to Fix Mailgun Reply-To handling.Mar 29 2014, 5:50 PM
carl updated this object.
carl edited the test plan for this revision. (Show Details)
carl added a reviewer: epriestley.
carl updated this revision to Diff 20501.
epriestley edited edge metadata.Mar 29 2014, 5:52 PM
epriestley accepted this revision.

Thanks!

This revision is now accepted and ready to land.Mar 29 2014, 5:52 PM
epriestley closed this revision.Mar 29 2014, 5:54 PM
epriestley updated this revision to Diff 20502.

Closed by commit rP213eea7bdd00 (authored by @carl, committed by @epriestley).