Page MenuHomePhabricator
Differential D8564

Use modern UI for OAuthServer details page
ClosedPublic
Actions

Authored by epriestley on Mar 18 2014, 5:37 PM.
Tags
None
Referenced Files
F14067266: D8564.diff
Tue, Nov 19, 2:07 PM
F14064586: D8564.diff
Tue, Nov 19, 12:05 AM
F14009173: D8564.id20319.diff
Wed, Oct 30, 11:45 AM
F14005738: D8564.diff
Sun, Oct 27, 6:42 PM
F13980395: D8564.diff
Oct 19 2024, 10:22 AM
Unknown Object (File)
Oct 13 2024, 10:14 PM
Unknown Object (File)
Oct 8 2024, 11:57 AM
Unknown Object (File)
Oct 2 2024, 2:29 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP5721560663de: Use modern UI for OAuthServer details page
Summary

Mostly just UI updates and policy enforcement. Improves error message when trying to authorize an already-authorized application.

Test Plan

Screen_Shot_2014-03-18_at_10.35.24_AM.png (1×1 px, 114 KB)

Screen_Shot_2014-03-18_at_10.35.22_AM.png (1×1 px, 114 KB)

Screen_Shot_2014-03-18_at_10.35.59_AM.png (1×1 px, 120 KB)

Diff Detail

Repository
rP Phabricator
Branch
oauths5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/oauthserver/controller/PhabricatorOAuthServerTestController.php:66XHP16TODO Comment
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Diff 20319.Mar 18 2014, 5:37 PM
epriestley retitled this revision from to Use modern UI for OAuthServer details page.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley.Mar 18 2014, 5:37 PM
epriestley planned changes to this revision.Mar 18 2014, 5:38 PM

Oops, need to remove some dead code.

epriestley updated this revision to Diff 20322.Mar 18 2014, 5:41 PM
  • Remove dead code.
btrahan accepted this revision.Mar 18 2014, 7:50 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2014, 7:50 PM
epriestley closed this revision.Mar 18 2014, 10:39 PM
epriestley updated this revision to Diff 20329.

Closed by commit rP5721560663de (authored by @epriestley).

Revision Contents
Changeset List

Diff 20319

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/oauthserver/application/PhabricatorApplicationOAuthServer.php

Loading...
View Options

src/applications/oauthserver/controller/PhabricatorOAuthServerTestController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientDeleteController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientViewController.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthServerClientQuery.php

Loading...
Phabricator · Built by Phacility